Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devnet): Local Gossamer Devnet #2008
feat(devnet): Local Gossamer Devnet #2008
Changes from all commits
89b4337
31b3494
b502b27
a515bae
3afd167
0469b5c
53f0d51
a94830d
d71bc2b
d2fc4f8
1526265
276d7c4
edea601
4bb5719
078eab3
37bc203
f2b0c2a
d77c1fc
fee9325
4d3cfc6
bc651d6
2cfbb59
ae168e1
2048bea
1e31f5d
f059130
d78d5ab
e3f4c08
c7fdbf7
50de22e
b44587c
7c9e88d
a79cee7
b20dbef
baf937b
9e8fe21
0c0d2de
d9d07be
3aed2bd
a226b83
9a9bb10
0cbd42f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have this file in the
docs
directory somewhere instead? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit usually build arguments and env variables are in uppercase out there, although lowercase works too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to be able to fiddle with the bootnodes at runtime with i.e.:
You could also split that string in multiple
ENV
if you want (i.e.BOOTNODE_PORT=7001
) using sensible defaults.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a case where we would want to adjust the bootnodes for the
gssmr
devnet.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least the IP address
10.5.0.2
could be changed if we change the docker network right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the next PR I do actually have to change the bootnode ports, so port will be configurable on
bob.Dockerfile
. I'm trying to hardcode the configuration foralice.Dockerfile
since that is the lead node. I think being explicit in this case shows that everything is dependant on alice. The dockerfiles that I'm creating here aren't meant to be used standalone, but actually only orchestrated using the docker-compose.yml