Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trie): memory leak fix in lib/trie #2009

Merged
merged 19 commits into from
Nov 23, 2021
Merged

fix(trie): memory leak fix in lib/trie #2009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
08875a5
Buffer and pool usage fixed and improved
qdm12 Nov 12, 2021
3f1350e
Do not copy when not needed
qdm12 Nov 15, 2021
67abf17
Run `go mod tidy`
qdm12 Nov 15, 2021
212b091
Simplify array copying
qdm12 Nov 16, 2021
e775110
Restore comment on `encodeBranch`
qdm12 Nov 18, 2021
69e3df4
Remove unneeded `make` for `hash`
qdm12 Nov 18, 2021
c3d036a
Fix buffer not put back in pool
qdm12 Nov 18, 2021
e28e649
return buffer write errors with context
qdm12 Nov 18, 2021
e2654f0
Change copy locks to read locks
qdm12 Nov 18, 2021
84c0bdc
Add RW mutex for leaf encoding field
qdm12 Nov 18, 2021
9c4b1eb
Fix memory leak on encoding error
qdm12 Nov 18, 2021
6e9ec9a
Remove unneeded encoding `make` for `branch`
qdm12 Nov 18, 2021
361cf75
`encodeChildsInParallel` to `encodeChildrenInParallel`
qdm12 Nov 18, 2021
c2aaec4
`encodeChildsSequentially` to `encodeChildrenSequentially`
qdm12 Nov 18, 2021
de28742
Fix commit suggestion
qdm12 Nov 18, 2021
095f21a
More error checking in `encodeBranch`
qdm12 Nov 19, 2021
330195b
Use `io.Writer` interface when possible
qdm12 Nov 19, 2021
ba58bd5
Use `defer` for read mutex unlocking
qdm12 Nov 22, 2021
0ae2bf1
Add TODOs
qdm12 Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ require (
github.com/urfave/cli v1.22.5
github.com/wasmerio/go-ext-wasm v0.3.2-0.20200326095750-0a32be6068ec
golang.org/x/crypto v0.0.0-20210813211128-0a44fdfbc16e
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1
google.golang.org/protobuf v1.27.1
)
Expand Down Expand Up @@ -174,6 +173,7 @@ require (
go.uber.org/multierr v1.7.0 // indirect
go.uber.org/zap v1.19.0 // indirect
golang.org/x/net v0.0.0-20210813160813-60bc85c4be6d // indirect
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c // indirect
golang.org/x/sys v0.0.0-20210816183151-1e6c022a8912 // indirect
golang.org/x/text v0.3.7 // indirect
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect
Expand Down
Loading