-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib/babe): implement secondary slot block production #2260
Merged
kishansagathiya
merged 43 commits into
development
from
kishan/feat/secondary-slot-block-production
Mar 4, 2022
Merged
Changes from 37 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
e41869d
feat(lib/babe): implement secondary slot block production
kishansagathiya ea2729c
Initialize the map
kishansagathiya 9d691a7
Merge branch 'development' into kishan/feat/secondary-slot-block-prod…
kishansagathiya a42b712
adjusting to new babe changes
kishansagathiya a3d7d4a
adjusting to new babe changes
kishansagathiya 25bddae
fixed some errors and addressed reviews
kishansagathiya 1c09237
Pass pre runtime digest through functions
kishansagathiya c25d9d6
adjusting some tests
kishansagathiya a9c0d07
removing unused params
kishansagathiya 454eab2
attempting to stress test
kishansagathiya 151482c
addressed reviews
kishansagathiya 25d7a92
fixing some more errors
kishansagathiya d771a94
rename
kishansagathiya 1bd089b
Small changes and TODO comments while debugging
kishansagathiya aea4766
pass lint
kishansagathiya 8e23302
small changes
kishansagathiya a7e027f
Update lib/babe/epoch_handler.go
kishansagathiya f2a407f
Merge branch 'kishan/feat/secondary-slot-block-production' of github.…
kishansagathiya 1550205
make sure epochData.secondary gets filled
kishansagathiya a06c66b
Update lib/babe/verify_integration_test.go
kishansagathiya b27b37a
Update lib/babe/epoch_handler.go
kishansagathiya 8b6a6d0
Update tests/stress/stress_test.go
kishansagathiya a9a9d11
addressed reviews
kishansagathiya f0aab84
more fixes
kishansagathiya 255fdd7
more fixes
kishansagathiya c7f1730
Merge branch 'development' into kishan/feat/secondary-slot-block-prod…
kishansagathiya 34f2605
feat(lib/babe): implement secondary vrf slot block production (#2307)
kishansagathiya c9b863a
Update lib/babe/epoch.go
kishansagathiya d1afc50
addressed reviews, modified tests
kishansagathiya 988395c
Merge branch 'kishan/feat/secondary-slot-block-production' of github.…
kishansagathiya e9b24a9
fixing lint
kishansagathiya 347a698
Addressed Eclesio's comments
kishansagathiya 11b326b
Update tests/stress/stress_test.go
kishansagathiya 4de8ed5
Using ToPreRuntimeDigest() method now
kishansagathiya 678b2f8
more of quentin's comments
kishansagathiya c182a0d
Merge branch 'kishan/feat/secondary-slot-block-production' of github.…
kishansagathiya 1291d1b
Merge branch 'development' into kishan/feat/secondary-slot-block-prod…
kishansagathiya 983af6e
Update lib/babe/epoch.go
kishansagathiya 0c8a7b0
Update lib/babe/epoch.go
kishansagathiya bc775c6
Update lib/babe/epoch.go
kishansagathiya 9d6d62e
removed a comment
kishansagathiya e71b76d
Merge branch 'development' of github.com:ChainSafe/gossamer into kish…
kishansagathiya 1a44de1
Merge branch 'kishan/feat/secondary-slot-block-production' of github.…
kishansagathiya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean here, the error is logged below no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have seen below part getting executed
gossamer/lib/babe/epoch_handler.go
Lines 73 to 76 in 67a9bbb
Because
errEpochPast
is being sent on the channel here, I should seeerror from epochHandler
in logs because of following codegossamer/lib/babe/babe.go
Lines 388 to 390 in 67a9bbb
I did not see
error from epochHandler
in the logs when I was running gossamerThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ok, maybe a deadlock? It would be nice to investigate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kishansagathiya can you open an issue for this?