chore(lib/trie): insert method inserts takes value as byte slice argument

[qdm12]

Changes

• Trie insert methods take a value byte slice as argument instead of a node
• This helps reduce complexity to implement trie metrics, and is also a continuation of lib/trie: refactor lib/trie/trie.go code #2208

Tests

go test -race ./internal/trie/... ./lib/trie/...

Issues

• Related to Instrument the trie with Prometheus metrics #2229

Primary Reviewer

• Anyone is welcome

[codecov]

Codecov Report

Merging #2296 (b3f1729) into development (9ac6642) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head b3f1729 differs from pull request most recent head 1427ee0. Consider uploading reports for the commit 1427ee0 to get more accurate results

@@               Coverage Diff               @@
##           development    #2296      +/-   ##
===============================================
- Coverage        57.60%   57.58%   -0.02%     
===============================================
  Files              211      211              
  Lines            27902    27906       +4     
===============================================
- Hits             16072    16069       -3     
- Misses           10197    10202       +5     
- Partials          1633     1635       +2     

Flag	Coverage Δ
unit-tests	57.58% <100.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
internal/trie/node/branch.go	100.00% <ø> (ø)
internal/trie/node/branch_encode.go	87.28% <100.00%> (ø)
lib/trie/trie.go	98.12% <100.00%> (-0.01%)	⬇️
dot/state/block_notify.go	81.90% <0.00%> (-8.58%)	⬇️
dot/telemetry/mailer.go	58.73% <0.00%> (-4.77%)	⬇️
dot/state/initialize.go	40.74% <0.00%> (-1.61%)	⬇️
dot/state/block_finalisation.go	43.97% <0.00%> (-0.67%)	⬇️
lib/runtime/wasmer/imports.go	48.51% <0.00%> (-0.16%)	⬇️
dot/state/block.go	44.92% <0.00%> (ø)
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ac6642...1427ee0. Read the comment docs.