chore(all): remove unneeded timer channel drains #3002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
commented
Dec 12, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #3002 +/- ##
===============================================
+ Coverage 51.86% 51.89% +0.02%
===============================================
Files 219 219
Lines 27724 27704 -20
===============================================
- Hits 14380 14376 -4
+ Misses 12118 12104 -14
+ Partials 1226 1224 -2 |
qdm12
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj and
kishansagathiya
as code owners
EclesioMeloJunior
approved these changes
Dec 13, 2022
timwu20
approved these changes
Jan 6, 2023
qdm12
force-pushed
the
qdm12/no-unneeded-timer-drains
branch
from
5d9b09a
to
7761da5
Compare
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
😭 Sorry I've been wrong and annoying everyone with draining timer channels when stopping them...
Basically (duh) a channel is just like any other pointer, so if it goes out of scope it gets GC'd. There is no need to drain it, even if it's buffered, as long as it goes out of scope, it'll get GC'd. So that means timers don't need to have their channels drained. The only reason to drain them (the timer documentation isn't so clear on that) is to reset them, which we don't use at all in our codebase (except once where the timer already expired and was drained)
Tests
Issues
Primary Reviewer