Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(internal/database): replace chaindb/badgerdb with pebbledb #3414

Closed
wants to merge 139 commits into from
Closed

feat(internal/database): replace chaindb/badgerdb with pebbledb #3414

wants to merge 139 commits into from

Conversation

EclesioMeloJunior
Copy link
Member

Changes

  • Removes all occurrences of chaindb from Gossamer source code
  • Introduces PebbleDB implementation to Gossamer under internals/database
  • Uses the same interface as chaindb

https://pkg.go.dev/github.com/cockroachdb/pebble

Tests

go test -tags integration github.com/ChainSafe/gossamer/internal/database

Issues

Primary Reviewer

@timwu20

@EclesioMeloJunior
wip: implementing a poc around warp sync
f3eb2eb
@EclesioMeloJunior
chore: include informative logs to debug sync
d7c07ef
@EclesioMeloJunior
chore: enable state trace logs and improve error for unfinalized ance…
428ff13 
…stor
@EclesioMeloJunior
wip: handle workers results
25b30d5
@EclesioMeloJunior
wip: handling workers results
d05fdec
@EclesioMeloJunior
chore: start ignoring peers + use idleTicker to check the pool
6e272a6
@EclesioMeloJunior
fix: use buffered channel for taskQueue + wip: implementing tip sync
39dd7c3
@EclesioMeloJunior
chore: enable state/grandpa/digest trace to investigate forced changes
fc081e1
@EclesioMeloJunior
chore: making changes to handling forced changes
7bc8038
@EclesioMeloJunior
chore: reset scheduled changes once a forced change applies
0a27158
@EclesioMeloJunior
chore: rollback basepath
bf6bb61
@EclesioMeloJunior
chore: wip tip sync
59cbaae
@EclesioMeloJunior
wip: tip sync impl
f9ca5a4
@EclesioMeloJunior
chore: complete tip sync adjusts
f9d7e43
@EclesioMeloJunior
chore: rollback modification on .yml files
3ba7e4c
@EclesioMeloJunior
chore: rollback modifications to digest pkg
16e8ee6
@EclesioMeloJunior
chore: rollback modification to network pkg
3eba164
@EclesioMeloJunior
chore: rollback modifications to auth set changes
c30948a
@EclesioMeloJunior
chore: remove internal/sync pkg
57f433c
@EclesioMeloJunior
chore: remove unneeded comments
a76c0e9
@EclesioMeloJunior
chore: remove unneeded fields from sync worker
0bd8505
@EclesioMeloJunior
chore: remove dead code + add errors wrappers
5102e62
@EclesioMeloJunior
chore: address some points
c13b597
@EclesioMeloJunior
chore: fix missing blocks in ascedingBlockRequests
f0c667f
@EclesioMeloJunior
Merge branch 'development' into eclesio/fix-bootstrap-sync
f3cb072
@EclesioMeloJunior
chore: delete chainprocessor.go from merge with development
2e640ce
@EclesioMeloJunior
chore: impl wait/release while validating a worker result
683e331
@EclesioMeloJunior
wip: tip sync concurrency for bounded requests
b3d4c8e
@EclesioMeloJunior
wip: bounded requests without blocking the task queue listener
c446fc0
@EclesioMeloJunior
Merge branch 'development' into eclesio/fix-bootstrap-sync
938d001
@EclesioMeloJunior
chore: fix TestNewNode test
9e2acb3
@EclesioMeloJunior
chore: fix TestStartStopNode test
1610978
@EclesioMeloJunior
Merge branch 'development' into eclesio/fix-bootstrap-sync
9f540b9
@EclesioMeloJunior
chore: include `TestChainSync_BootstrapSync_SucessfulSync_ReceivedPar…
bb6e4d7 
…tialBlockData` test
@EclesioMeloJunior
Merge branch 'eclesio/fix-bootstrap-sync' of github.com:ChainSafe/gos…
4741a28 
…samer into eclesio/fix-bootstrap-sync
@EclesioMeloJunior
chore: address comments
f1f0078
@EclesioMeloJunior
Merge branch 'development' into eclesio/fix-bootstrap-sync
b60486b
@EclesioMeloJunior
chore: solve lint warns
6ba9c73
@EclesioMeloJunior
Merge branch 'eclesio/fix-bootstrap-sync' of github.com:ChainSafe/gos…
268f572 
…samer into eclesio/fix-bootstrap-sync
@EclesioMeloJunior
Merge branch 'development' into eclesio/fix-bootstrap-sync
bf87577
@EclesioMeloJunior
Merge branch 'development' into eclesio/fix-bootstrap-sync
d50c7fc
@EclesioMeloJunior
chore: address comments
7dc13c0
@EclesioMeloJunior
wip: introduce pebbledb, remove chaindb/badger
7ced027
@EclesioMeloJunior
chore: enable sync trace logs
b657974
@EclesioMeloJunior
Merge branch 'development' into eclesio/pebbledb
1b21120
@EclesioMeloJunior EclesioMeloJunior marked this pull request as draft July 31, 2023 18:32
@EclesioMeloJunior
Copy link
Member Author

Closing in favor of #3434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardmack edwardmack Awaiting requested review from edwardmack

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj is a code owner

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya kishansagathiya is a code owner

@dimartiro dimartiro Awaiting requested review from dimartiro

@kanishkatn kanishkatn Awaiting requested review from kanishkatn

@P1sar P1sar Awaiting requested review from P1sar P1sar will be requested when the pull request is marked ready for review P1sar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gossamer panics with runtime error: slice bounds out of range [:-8]
1 participant
@EclesioMeloJunior