feat(wazero): Add v2 runtime functions #3428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimartiro
force-pushed
the
diego/trieV1/runtime-functions
branch
from
f609a18
to
76767e9
Compare
10 tasks
dimartiro
changed the title
… 0.11.0 (#3441) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… to 10.15.0 (#3439) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
….2 (#3440) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dimartiro
force-pushed
the
diego/trieV1/runtime-functions
branch
from
7730bf8
to
793d80c
Compare
…e/gossamer into diego/trieV1/runtime-functions
…nto diego/trieV1/runtime-functions
dimartiro
requested review from
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya and
kanishkatn
as code owners
EclesioMeloJunior
requested changes
Sep 8, 2023
| testinput := []string{"dimartiro", "was", "here", "??"} | ||
| encInput, err := scale.Marshal(testinput) | ||
| require.NoError(t, err) | ||
| encInput[0] = encInput[0] >> 1 |
There was a problem hiding this comment.
Why do you right shift the first index of encInput?
There was a problem hiding this comment.
Actually a very good question, I based this in the one Elizabeth made for v1. I asked Tim about this right shift a few days ago to see if he knows anything. Will investigate it more about it
EclesioMeloJunior
requested changes
Sep 13, 2023
…e/gossamer into diego/trieV1/runtime-functions
…e/gossamer into diego/trieV1/runtime-functions
…e/gossamer into diego/trieV1/runtime-functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR is a continuation of #2664
Changes
ext_trie_blake2_256_root_version_2ext_trie_blake2_256_ordered_root_version_2ext_trie_blake2_256_verify_proof_version_2ext_default_child_storage_root_version_2ext_storage_root_version_2Blocked by #3433
Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
#2418
Primary Reviewer
@timwu20