wait for babe goroutines to complete when calling babe.Service.Close() #3442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwu20
requested review from
edwardmack,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya,
dimartiro and
kanishkatn
as code owners
timwu20
commented
Aug 14, 2023
| err = babeService.Stop() | ||
| require.NoError(t, err) | ||
| } | ||
| // func TestService_PauseAndResume(t *testing.T) { |
There was a problem hiding this comment.
This test still produces a panic. The entire orchestration of this service needs to be revisited.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## eclesio/introduce-pebbledb #3442 +/- ##
==============================================================
- Coverage 50.06% 50.05% -0.02%
==============================================================
Files 233 234 +1
Lines 30759 30775 +16
==============================================================
+ Hits 15401 15403 +2
- Misses 13655 13670 +15
+ Partials 1703 1702 -1 |
|
Closing in favor of #3434 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@EclesioMeloJunior