-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(.github/contrib): add commits and PR styleguide to contribmd #3634
Merged
P1sar
merged 12 commits into
development
from
p1sar/chore/include-commit-styleguide-to-contribmd
Jan 5, 2024
Merged
docs(.github/contrib): add commits and PR styleguide to contribmd #3634
P1sar
merged 12 commits into
development
from
p1sar/chore/include-commit-styleguide-to-contribmd
Jan 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P1sar
requested review from
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya,
dimartiro,
kanishkatn and
axaysagathiya
as code owners
December 8, 2023 12:51
dimartiro
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with suggestions to improve the style
Co-authored-by: Diego Romero <diego2737@gmail.com>
Co-authored-by: Diego Romero <diego2737@gmail.com>
Co-authored-by: Diego Romero <diego2737@gmail.com>
Co-authored-by: Diego Romero <diego2737@gmail.com>
Co-authored-by: Diego Romero <diego2737@gmail.com>
kishansagathiya
approved these changes
Dec 11, 2023
🎉 This PR is included in version 0.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Moved commits and PRs internal stylguide from notion to the contributors.md to be available for all contributors of gossamer
Tests
go test -tags integration github.com/ChainSafe/gossamer
Issues
Primary Reviewer
@timwu20