Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(.github/contrib): add commits and PR styleguide to contribmd #3634

Merged
merged 12 commits into from
Jan 5, 2024

Conversation

P1sar
Copy link
Member

@P1sar P1sar commented Dec 7, 2023

Changes

Moved commits and PRs internal stylguide from notion to the contributors.md to be available for all contributors of gossamer

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

Primary Reviewer

@timwu20

Copy link
Contributor

@dimartiro dimartiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions to improve the style

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
P1sar and others added 6 commits December 11, 2023 07:39
Co-authored-by: Diego Romero <diego2737@gmail.com>
Co-authored-by: Diego Romero <diego2737@gmail.com>
Co-authored-by: Diego Romero <diego2737@gmail.com>
Co-authored-by: Diego Romero <diego2737@gmail.com>
Co-authored-by: Diego Romero <diego2737@gmail.com>
@P1sar P1sar merged commit 49709f0 into development Jan 5, 2024
24 checks passed
@P1sar P1sar deleted the p1sar/chore/include-commit-styleguide-to-contribmd branch January 5, 2024 13:45
EclesioMeloJunior pushed a commit that referenced this pull request Jan 10, 2024
)

Co-authored-by: Diego Romero <diego2737@gmail.com>
Copy link

github-actions bot commented Mar 1, 2024

🎉 This PR is included in version 0.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

timwu20 pushed a commit that referenced this pull request Apr 18, 2024
)

Co-authored-by: Diego Romero <diego2737@gmail.com>
timwu20 pushed a commit that referenced this pull request Apr 19, 2024
)

Co-authored-by: Diego Romero <diego2737@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants