Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/cli: add paseo config #3677

Merged
merged 2 commits into from
Jan 15, 2024
Merged

chore/cli: add paseo config #3677

merged 2 commits into from
Jan 15, 2024

Conversation

kanishkatn
Copy link
Contributor

@kanishkatn kanishkatn commented Jan 11, 2024

Changes

Adds the paseo chain-spec to the project and supports it in the cli.

Issues

#3671

Primary Reviewer

@EclesioMeloJunior

Copy link
Contributor

@q9f q9f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the XDG changes before merging this

@kanishkatn
Copy link
Contributor Author

kanishkatn commented Jan 12, 2024

please remove the XDG changes before merging this

It's done. Thank you!

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f7e690f) 50.20% compared to head (9891c83) 50.24%.
Report is 1 commits behind head on development.

❗ Current head 9891c83 differs from pull request most recent head 0f26242. Consider uploading reports for the commit 0f26242 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #3677      +/-   ##
===============================================
+ Coverage        50.20%   50.24%   +0.03%     
===============================================
  Files              229      229              
  Lines            28590    28593       +3     
===============================================
+ Hits             14354    14366      +12     
+ Misses           12715    12706       -9     
  Partials          1521     1521              

@kanishkatn
Copy link
Contributor Author

Moving out the renaming to a different PR to sort out the CI issues. My bad.

@EclesioMeloJunior @dimartiro Paging to take another look at this!

@q9f q9f merged commit 92ae2ba into development Jan 15, 2024
22 of 23 checks passed
@q9f q9f deleted the feat/paseo-config branch January 15, 2024 13:26
Copy link

github-actions bot commented Mar 1, 2024

🎉 This PR is included in version 0.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

timwu20 pushed a commit that referenced this pull request Apr 18, 2024
Co-authored-by: Afri <58883403+q9f@users.noreply.github.com>
timwu20 pushed a commit that referenced this pull request Apr 19, 2024
Co-authored-by: Afri <58883403+q9f@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants