decode messages to wire message #4188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collation protocol and validation protocol uses messages wrapped as wiremessage. So we had to adjust our decoder and handler functions according to that. Apart from this I have also added message type to wire message struct. Since wire message could be collation message or validation message, I have chose to manually set this as a value instead of returning a hardcoded value.
kishansagathiya
requested review from
EclesioMeloJunior,
jimjbrettj and
timwu20
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collation protocol and validation protocol uses messages wrapped as wiremessage. So we had to adjust our decoder and handler functions according to that.
Apart from this I have also added message type to wire message struct. Since wire message could be collation message or validation message, I have chose to manually set this as a value instead of returning a hardcoded value.
Changes
Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
#4108