Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scale: encode/decode []string in struct #560

Merged
merged 11 commits into from
Jan 24, 2020

Conversation

edwardmack
Copy link
Member

This PR introduces the ability to SCALE encode and decode structs that contain arrays of strings.

Changes

  • Added ability to encode/decode []string
  • Added tests for testing encoding/decoding []string

Tests:

go test -v ./codec/...

Issues:

closes #394

Copy link
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work :D

Copy link
Contributor

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This looks good to me.

@edwardmack edwardmack merged commit 0dd471a into development Jan 24, 2020
@edwardmack edwardmack deleted the ed/encode_strings_struct branch January 24, 2020 15:38
ryanchristo pushed a commit that referenced this pull request Jun 24, 2020
* create encoder for []string

* save commit

* added ability to decode []string

* go fmt project

* removed extra logging

* cleanup error check

* refactor flow

* added DecodeStringArray function

* go fmt code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scale: array of strings in struct not decoding
3 participants