dot/rpc: Implement RPC method author_hasKey #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noot
reviewed
May 21, 2020
noot
reviewed
May 21, 2020
dot/core/service.go
Outdated
| return false, err | ||
| } | ||
| cKeyType := keystore.DetermineKeyType(keyType) | ||
| var err2 error |
There was a problem hiding this comment.
I thought I had an issue with shadowing, but I see now that I didn't... Updated.
noot
reviewed
May 21, 2020
| @@ -496,6 +497,31 @@ func (s *Service) InsertKey(kp crypto.Keypair) { | |||
| s.keys.Insert(kp) | |||
| } | |||
|
|
|||
| // HasKey returns true if given hex encoded public key string is found in keystore, false otherwise, error if there | |||
| // are issues decoding string | |||
| func (s *Service) HasKey(pubKeyStr string, keyType string) (bool, error) { | |||
There was a problem hiding this comment.
this would probably be better as a function in the keystore package that can be wrapped by core
ryanchristo
approved these changes
May 21, 2020
There was a problem hiding this comment.
Nothing to add, just the comments from @noot. The main request for me would be moving HasKey to keystore to make it reusable elsewhere. Otherwise, looking good. Nothing blocking.
Updated key handling for grandpa to use Ed25519 type keys.
|
I've moved HasKey to keystore, and addressed other comments. This is ready for another look. |
thomasmodeneis
approved these changes
May 22, 2020
ryanchristo
pushed a commit
that referenced
this pull request
Jun 24, 2020
* add stub for rpc call author_hasKey * implement rpc author_hasKey * add tests * update service test * add tests * Move HasKey function to keystore package. Updated key handling for grandpa to use Ed25519 type keys.
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests:
Checklist:
Issues: