fix: ignore new closed connection (#399)

* fix: ignore new closed connection * fix: update src/metrics.ts Co-authored-by: Cayman <caymannava@gmail.com>
ChainSafe · Jan 19, 2023 · 20d54f4 · 20d54f4
1 parent 4842680
commit 20d54f4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/index.ts b/src/index.ts
@@ -698,7 +698,10 @@ export class GossipSub extends EventEmitter<GossipsubEvents> implements PubSub<G
    * Registrar notifies an established connection with pubsub protocol
    */
   private onPeerConnected(peerId: PeerId, connection: Connection): void {
-    if (!this.isStarted()) {
+    this.metrics?.newConnectionCount.inc({ status: connection.stat.status })
+    // libp2p may emit a closed connection and never issue peer:disconnect event
+    // see https://github.com/ChainSafe/js-libp2p-gossipsub/issues/398
+    if (!this.isStarted() || connection.stat.status !== 'OPEN') {
       return
     }
 

diff --git a/src/metrics.ts b/src/metrics.ts
@@ -512,6 +512,12 @@ export function getMetrics(
       help: 'Total count of key collisions on fastmsgid cache put'
     }),
 
+    newConnectionCount: register.gauge<{ status: string }>({
+      name: 'gossipsub_new_connection_total',
+      help: 'Total new connection by status',
+      labelNames: ['status']
+    }),
+
     topicStrToLabel: topicStrToLabel,
 
     toTopic(topicStr: TopicStr): TopicLabel {