fix: track promise only after a successful sendRpc() (#415)

* fix: track promise only after a successful sendRpc() * feat: add iwant_promise_untracked metric * Update src/index.ts --------- Co-authored-by: Cayman <caymannava@gmail.com>
ChainSafe · Mar 23, 2023 · a959b09 · a959b09
1 parent 5b3aee9
commit a959b09
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -1275,7 +1275,15 @@ export class GossipSub extends EventEmitter<GossipsubEvents> implements PubSub<G
       return
     }
 
-    this.sendRpc(id, { messages: ihave, control: { iwant, prune } })
+    const sent = this.sendRpc(id, { messages: ihave, control: { iwant, prune } })
+    const iwantMessageIds = iwant[0]?.messageIDs
+    if (iwantMessageIds) {
+      if (sent) {
+        this.gossipTracer.addPromise(id, iwantMessageIds)
+      } else {
+        this.metrics?.iwantPromiseUntracked.inc(1)
+      }
+    }
   }
 
   /**
@@ -1385,7 +1393,7 @@ export class GossipSub extends EventEmitter<GossipsubEvents> implements PubSub<G
     iwantList = iwantList.slice(0, iask)
     this.iasked.set(id, iasked + iask)
 
-    this.gossipTracer.addPromise(id, iwantList)
+    // do not add gossipTracer promise here until a successful sendRpc()
 
     return [
       {

diff --git a/src/metrics.ts b/src/metrics.ts
@@ -509,6 +509,10 @@ export function getMetrics(
         4 * opts.gossipPromiseExpireSec
       ]
     }),
+    iwantPromiseUntracked: register.gauge({
+      name: 'gossip_iwant_promise_untracked',
+      help: 'Total count of untracked IWANT promise'
+    }),
 
     /* Data structure sizes */
     /** Unbounded cache sizes */