Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore new closed connection #399

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Jan 19, 2023

Motivation

Description

  • Handle that in onPeerConnected
  • Add a metric to track it

Closes #398

@twoeths twoeths requested a review from a team as a code owner January 19, 2023 09:05
@codecov-commenter
Copy link

Codecov Report

Base: 83.41% // Head: 83.41% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (c112df0) compared to base (41740b5).
Patch coverage: 89.02% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
- Coverage   83.41%   83.41%   -0.01%     
==========================================
  Files          48       48              
  Lines       11766    11779      +13     
  Branches     1266     1270       +4     
==========================================
+ Hits         9815     9825      +10     
- Misses       1951     1954       +3     
Impacted Files Coverage Δ
src/metrics.ts 21.57% <0.00%> (-0.19%) ⬇️
src/score/peer-score-params.ts 98.21% <91.42%> (+0.75%) ⬆️
src/index.ts 70.51% <100.00%> (+0.07%) ⬆️
src/score/peer-score-thresholds.ts 100.00% <100.00%> (ø)
src/types.ts 94.54% <100.00%> (+0.13%) ⬆️
test/gossip.spec.ts 96.62% <100.00%> (+0.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

dapplion
dapplion previously approved these changes Jan 19, 2023
src/metrics.ts Outdated Show resolved Hide resolved
@wemeetagain wemeetagain merged commit 20d54f4 into master Jan 19, 2023
@wemeetagain wemeetagain deleted the tuyen/ignore_new_closed_connection branch January 19, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leaked outbound and peers
4 participants