Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New option for publish api to ignore duplicate #402

Closed
twoeths opened this issue Feb 14, 2023 · 0 comments · Fixed by #404
Closed

New option for publish api to ignore duplicate #402

twoeths opened this issue Feb 14, 2023 · 0 comments · Fixed by #404

Comments

@twoeths
Copy link
Contributor

twoeths commented Feb 14, 2023

Description

  • Right now when lodestar publishes a block, builder may already published it and gossipsub throw Duplicate error in publish api
  • I'd like to add ignoreDuplicate (or probably allowDuplicate?) option to publish api to return early and ignore the error

this is the root cause of ChainSafe/lodestar#5140
maschad added a commit to maschad/js-libp2p-gossipsub that referenced this issue Feb 14, 2023
@maschad
feat: allow for duplicate messages (ChainSafe#402)
f7f59cd
@maschad maschad mentioned this issue Feb 14, 2023
Merged
@twoeths twoeths mentioned this issue Feb 14, 2023
Closed
maschad added a commit to maschad/js-libp2p-gossipsub that referenced this issue Feb 15, 2023
@maschad
feat: return empty array if ignoreDuplicateMessages is enabled (Chain…
64780ed 
…Safe#402)
maschad added a commit to maschad/js-libp2p-gossipsub that referenced this issue Feb 15, 2023
@maschad
feat: added gauge metric for tracking ignored duplicate messages (Cha…
6c8c0c2 
…inSafe#402)
maschad added a commit to maschad/js-libp2p-gossipsub that referenced this issue Feb 16, 2023
@maschad
feat: updated metric name for gauge to include published messages tha…
2d30405 
…t are ignored (ChainSafe#402)
maschad added a commit to maschad/js-libp2p-gossipsub that referenced this issue Feb 20, 2023
@maschad
chore: updated name to ignoreDuplicatePublishError (ChainSafe#402)
5906a27
wemeetagain added a commit that referenced this issue Feb 21, 2023
@maschad @wemeetagain
feat: allow ignoring PublishError.Duplicate (#404)
dcde3c9 
* feat: allow for duplicate messages (#402)

* feat: return empty array if ignoreDuplicateMessages is enabled (#402)

* feat: added gauge metric for tracking ignored duplicate messages (#402)

* feat: updated metric name for gauge to include published messages that are ignored (#402)

* chore: renaming

* chore: fix linter error

* chore: updated name to ignoreDuplicatePublishError (#402)

---------

Co-authored-by: Cayman <caymannava@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow ignoring PublishError.Duplicate maschad/js-libp2p-gossipsub
1 participant
@twoeths