chore: pr comments

ChainSafe · Aug 2, 2023 · 2751450 · 2751450
1 parent 61ba47b
commit 2751450
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/muxer.ts b/src/muxer.ts
@@ -275,7 +275,6 @@ export class YamuxMuxer implements StreamMuxer {
     options.signal = options.signal ?? AbortSignal.timeout(CLOSE_TIMEOUT)
 
     try {
-      // If err is provided, abort all underlying streams, else close all underlying streams
       await Promise.all(
         [...this._streams.values()].map(async s => s.close(options))
       )

diff --git a/src/stream.ts b/src/stream.ts
@@ -108,7 +108,10 @@ export class YamuxStream extends AbstractStream {
 
   /**
    * Send a message to the remote muxer informing them a new stream is being
-   * opened
+   * opened.
+   *
+   * This is a noop for Yamux because the first window update is sent when
+   * .newStream is called on the muxer which opens the stream on the remote.
    */
   async sendNewStream (): Promise<void> {