fix: silence max listeners exceeded warning #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have more than 10x streams open accross all yamux muxer instances node will log warnings about too many listeners being added to the shutdown controller signal. This is fine, increase the max number of listeners.
Codecov ReportAttention:
📢 Thoughts on this report? Let us know! |
wemeetagain
approved these changes
Nov 12, 2023
|
🎉 This PR is included in version 5.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have more than 10x streams open accross all yamux muxer instances node will log warnings about too many listeners being added to the shutdown controller signal.
This is fine, increase the max number of listeners.
Also, where we create an abort signal for the close call, clone the options object instead of adding our signal to it, it's pretty common for people to pass an
optionsobject to several calls, this way we don't accidentally add a signal to an onwards method invocation 😬 .