Discv5 worker #4988
Merged
Discv5 worker #4988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
commented
Jan 9, 2023
Comment on lines
+72
to
+73
| // TODO there is a bug in enr encoding(?) that causes many enrs to be incorrectly encoded (and thus incorrectly decoded) | ||
| // this.logger.error("Unable to decode enr", {enr: Buffer.from(enrStr).toString("hex")}, e as Error); |
There was a problem hiding this comment.
There seems to be a bug in ENR encoding?
Uncommenting this results in a flood of error logs.
wemeetagain
commented
Jan 9, 2023
| @@ -35,7 +34,7 @@ export interface IMetadataModules { | |||
| * https://github.com/ethereum/consensus-specs/blob/v1.1.10/specs/phase0/p2p-interface.md#metadata | |||
| */ | |||
| export class MetadataController { | |||
| private enr?: ENR; | |||
| private setEnrValue?: (key: string, value: Uint8Array) => Promise<void>; | |||
There was a problem hiding this comment.
Someone has to 'own' the ENR.
Current choice is for the discv5 worker to own the ENR and just pass a function here to update it.
The FileENR should also be removed and we just write the ENR to disk on close.
Merged
Performance Report✔️ no performance regression detected Full benchmark results
|
|
Good starting point! observables seems sufficient to fullfil the need of events here. To safely merge this we need high observability of the metrics of the worker. This blog is great at how to collect basically all data points we need from the worker https://prog.world/monitoring-multithreaded-node-js-applications/ Regarding metrics the approach of just fetching the metrics str is good for now. Also I think we should move to the pattern of the discv5 library creating the metrics names itself, like we do in gossipsub now. |
|
Added some vm-level metrics and appended to the discv5 dashboard |
|
@dapplion @tuyennhv let me know what kind of other metrics you'd like to see |
|
looks great 👍 , can't think of other metrics to add |
philknows
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, opening for initial review / discussion.
Deployed on
nogroup-hzax41-0and thebetagroup