Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment on PRs included in release #5234

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Comment on PRs included in release #5234

merged 1 commit into from
Mar 6, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Mar 6, 2023 •
edited
Loading

Motivation

Make it easier to track in which release a PR was included.

Description

Comment on PRs included in stable release by adding GitHub Action: Comment on Pull Requests included in Release to publish stable workflow.

By default the message looks like this:

🎉 This PR is included in v1.5.0 🎉

We can customize that if needed by setting the message, see inputs.

@nflaig nflaig marked this pull request as ready for review March 6, 2023 12:34
@nflaig nflaig requested a review from a team as a code owner March 6, 2023 12:34
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: c5f2fe3 Previous: eca63ad Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 951.98 us/op 612.18 us/op 1.56
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 48.126 us/op 56.001 us/op 0.86
BLS verify - blst-native 1.2556 ms/op 1.3128 ms/op 0.96
BLS verifyMultipleSignatures 3 - blst-native 2.5539 ms/op 2.6814 ms/op 0.95
BLS verifyMultipleSignatures 8 - blst-native 5.5173 ms/op 5.7361 ms/op 0.96
BLS verifyMultipleSignatures 32 - blst-native 19.952 ms/op 21.015 ms/op 0.95
BLS aggregatePubkeys 32 - blst-native 26.674 us/op 27.673 us/op 0.96
BLS aggregatePubkeys 128 - blst-native 104.85 us/op 107.11 us/op 0.98
getAttestationsForBlock 58.033 ms/op 62.538 ms/op 0.93
isKnown best case - 1 super set check 263.00 ns/op 272.00 ns/op 0.97
isKnown normal case - 2 super set checks 266.00 ns/op 269.00 ns/op 0.99
isKnown worse case - 16 super set checks 262.00 ns/op 267.00 ns/op 0.98
CheckpointStateCache - add get delete 5.2550 us/op 5.8110 us/op 0.90
validate gossip signedAggregateAndProof - struct 2.8689 ms/op 2.9988 ms/op 0.96
validate gossip attestation - struct 1.3679 ms/op 1.4373 ms/op 0.95
pickEth1Vote - no votes 1.3105 ms/op 1.6046 ms/op 0.82
pickEth1Vote - max votes 9.2148 ms/op 14.479 ms/op 0.64
pickEth1Vote - Eth1Data hashTreeRoot value x2048 9.0364 ms/op 9.9415 ms/op 0.91
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 14.069 ms/op 17.473 ms/op 0.81
pickEth1Vote - Eth1Data fastSerialize value x2048 754.92 us/op 851.81 us/op 0.89
pickEth1Vote - Eth1Data fastSerialize tree x2048 5.0540 ms/op 5.5774 ms/op 0.91
bytes32 toHexString 547.00 ns/op 594.00 ns/op 0.92
bytes32 Buffer.toString(hex) 363.00 ns/op 425.00 ns/op 0.85
bytes32 Buffer.toString(hex) from Uint8Array 573.00 ns/op 636.00 ns/op 0.90
bytes32 Buffer.toString(hex) + 0x 369.00 ns/op 423.00 ns/op 0.87
Object access 1 prop 0.17400 ns/op 0.19700 ns/op 0.88
Map access 1 prop 0.17300 ns/op 0.16800 ns/op 1.03
Object get x1000 7.5540 ns/op 7.0450 ns/op 1.07
Map get x1000 0.63400 ns/op 0.68800 ns/op 0.92
Object set x1000 55.837 ns/op 66.746 ns/op 0.84
Map set x1000 46.094 ns/op 52.210 ns/op 0.88
Return object 10000 times 0.25130 ns/op 0.25760 ns/op 0.98
Throw Error 10000 times 4.3734 us/op 4.5165 us/op 0.97
fastMsgIdFn sha256 / 200 bytes 3.6020 us/op 3.8000 us/op 0.95
fastMsgIdFn h32 xxhash / 200 bytes 288.00 ns/op 320.00 ns/op 0.90
fastMsgIdFn h64 xxhash / 200 bytes 434.00 ns/op 475.00 ns/op 0.91
fastMsgIdFn sha256 / 1000 bytes 12.031 us/op 12.599 us/op 0.95
fastMsgIdFn h32 xxhash / 1000 bytes 429.00 ns/op 451.00 ns/op 0.95
fastMsgIdFn h64 xxhash / 1000 bytes 523.00 ns/op 558.00 ns/op 0.94
fastMsgIdFn sha256 / 10000 bytes 107.50 us/op 111.17 us/op 0.97
fastMsgIdFn h32 xxhash / 10000 bytes 2.0440 us/op 2.1240 us/op 0.96
fastMsgIdFn h64 xxhash / 10000 bytes 1.5160 us/op 1.5190 us/op 1.00
enrSubnets - fastDeserialize 64 bits 1.4780 us/op 1.5380 us/op 0.96
enrSubnets - ssz BitVector 64 bits 557.00 ns/op 608.00 ns/op 0.92
enrSubnets - fastDeserialize 4 bits 207.00 ns/op 200.00 ns/op 1.03
enrSubnets - ssz BitVector 4 bits 552.00 ns/op 602.00 ns/op 0.92
prioritizePeers score -10:0 att 32-0.1 sync 2-0 115.98 us/op 131.90 us/op 0.88
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 148.74 us/op 161.59 us/op 0.92
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 183.02 us/op 200.35 us/op 0.91
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 361.13 us/op 398.37 us/op 0.91
prioritizePeers score 0:0 att 64-1 sync 4-1 415.61 us/op 476.28 us/op 0.87
array of 16000 items push then shift 1.7355 us/op 1.9133 us/op 0.91
LinkedList of 16000 items push then shift 9.2420 ns/op 10.136 ns/op 0.91
array of 16000 items push then pop 117.61 ns/op 123.19 ns/op 0.95
LinkedList of 16000 items push then pop 9.1950 ns/op 9.3660 ns/op 0.98
array of 24000 items push then shift 2.4635 us/op 2.6315 us/op 0.94
LinkedList of 24000 items push then shift 9.0680 ns/op 10.539 ns/op 0.86
array of 24000 items push then pop 82.974 ns/op 93.960 ns/op 0.88
LinkedList of 24000 items push then pop 8.9650 ns/op 9.6640 ns/op 0.93
intersect bitArray bitLen 8 13.633 ns/op 15.333 ns/op 0.89
intersect array and set length 8 84.751 ns/op 109.35 ns/op 0.78
intersect bitArray bitLen 128 45.496 ns/op 49.672 ns/op 0.92
intersect array and set length 128 1.1314 us/op 1.3821 us/op 0.82
Buffer.concat 32 items 3.1600 us/op 3.1300 us/op 1.01
Uint8Array.set 32 items 2.2420 us/op 2.7290 us/op 0.82
pass gossip attestations to forkchoice per slot 3.4774 ms/op 2.6448 ms/op 1.31
computeDeltas 3.1003 ms/op 3.3176 ms/op 0.93
computeProposerBoostScoreFromBalances 1.8594 ms/op 1.9459 ms/op 0.96
altair processAttestation - 250000 vs - 7PWei normalcase 3.2119 ms/op 3.7055 ms/op 0.87
altair processAttestation - 250000 vs - 7PWei worstcase 4.6192 ms/op 4.7027 ms/op 0.98
altair processAttestation - setStatus - 1/6 committees join 149.85 us/op 161.29 us/op 0.93
altair processAttestation - setStatus - 1/3 committees join 303.23 us/op 330.21 us/op 0.92
altair processAttestation - setStatus - 1/2 committees join 407.02 us/op 415.43 us/op 0.98
altair processAttestation - setStatus - 2/3 committees join 491.85 us/op 509.75 us/op 0.96
altair processAttestation - setStatus - 4/5 committees join 703.41 us/op 740.16 us/op 0.95
altair processAttestation - setStatus - 100% committees join 806.38 us/op 830.42 us/op 0.97
altair processBlock - 250000 vs - 7PWei normalcase 18.133 ms/op 18.242 ms/op 0.99
altair processBlock - 250000 vs - 7PWei normalcase hashState 30.554 ms/op 29.630 ms/op 1.03
altair processBlock - 250000 vs - 7PWei worstcase 52.461 ms/op 58.700 ms/op 0.89
altair processBlock - 250000 vs - 7PWei worstcase hashState 73.544 ms/op 77.059 ms/op 0.95
phase0 processBlock - 250000 vs - 7PWei normalcase 2.3963 ms/op 2.5547 ms/op 0.94
phase0 processBlock - 250000 vs - 7PWei worstcase 31.944 ms/op 32.491 ms/op 0.98
altair processEth1Data - 250000 vs - 7PWei normalcase 564.34 us/op 596.87 us/op 0.95
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 11.409 us/op 13.943 us/op 0.82
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 27.933 us/op 31.101 us/op 0.90
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 11.941 us/op 12.060 us/op 0.99
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 7.9270 us/op 10.772 us/op 0.74
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 108.87 us/op 121.61 us/op 0.90
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 674.00 us/op 820.54 us/op 0.82
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 937.85 us/op 1.0291 ms/op 0.91
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 920.16 us/op 1.1334 ms/op 0.81
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 2.4350 ms/op 3.8254 ms/op 0.64
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 1.6033 ms/op 2.0103 ms/op 0.80
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 4.1414 ms/op 4.9675 ms/op 0.83
Tree 40 250000 create 308.89 ms/op 623.69 ms/op 0.50
Tree 40 250000 get(125000) 189.55 ns/op 209.92 ns/op 0.90
Tree 40 250000 set(125000) 935.83 ns/op 1.4069 us/op 0.67
Tree 40 250000 toArray() 20.562 ms/op 25.125 ms/op 0.82
Tree 40 250000 iterate all - toArray() + loop 20.254 ms/op 23.320 ms/op 0.87
Tree 40 250000 iterate all - get(i) 75.655 ms/op 77.059 ms/op 0.98
MutableVector 250000 create 10.579 ms/op 11.000 ms/op 0.96
MutableVector 250000 get(125000) 6.6210 ns/op 7.1620 ns/op 0.92
MutableVector 250000 set(125000) 298.34 ns/op 345.14 ns/op 0.86
MutableVector 250000 toArray() 3.5195 ms/op 3.8356 ms/op 0.92
MutableVector 250000 iterate all - toArray() + loop 4.1492 ms/op 4.1497 ms/op 1.00
MutableVector 250000 iterate all - get(i) 1.5760 ms/op 1.6184 ms/op 0.97
Array 250000 create 3.5971 ms/op 3.4657 ms/op 1.04
Array 250000 clone - spread 1.2284 ms/op 1.2896 ms/op 0.95
Array 250000 get(125000) 0.65800 ns/op 0.64200 ns/op 1.02
Array 250000 set(125000) 0.67000 ns/op 0.72800 ns/op 0.92
Array 250000 iterate all - loop 86.715 us/op 87.127 us/op 1.00
effectiveBalanceIncrements clone Uint8Array 300000 38.464 us/op 40.664 us/op 0.95
effectiveBalanceIncrements clone MutableVector 300000 346.00 ns/op 408.00 ns/op 0.85
effectiveBalanceIncrements rw all Uint8Array 300000 174.35 us/op 179.84 us/op 0.97
effectiveBalanceIncrements rw all MutableVector 300000 88.691 ms/op 111.51 ms/op 0.80
phase0 afterProcessEpoch - 250000 vs - 7PWei 118.68 ms/op 123.36 ms/op 0.96
phase0 beforeProcessEpoch - 250000 vs - 7PWei 43.701 ms/op 40.262 ms/op 1.09
altair processEpoch - mainnet_e81889 335.46 ms/op 352.85 ms/op 0.95
mainnet_e81889 - altair beforeProcessEpoch 53.908 ms/op 54.421 ms/op 0.99
mainnet_e81889 - altair processJustificationAndFinalization 21.607 us/op 20.266 us/op 1.07
mainnet_e81889 - altair processInactivityUpdates 5.8390 ms/op 6.4811 ms/op 0.90
mainnet_e81889 - altair processRewardsAndPenalties 66.133 ms/op 73.142 ms/op 0.90
mainnet_e81889 - altair processRegistryUpdates 3.0570 us/op 5.5380 us/op 0.55
mainnet_e81889 - altair processSlashings 454.00 ns/op 651.00 ns/op 0.70
mainnet_e81889 - altair processEth1DataReset 542.00 ns/op 1.7620 us/op 0.31
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2589 ms/op 1.4644 ms/op 0.86
mainnet_e81889 - altair processSlashingsReset 3.5110 us/op 6.1520 us/op 0.57
mainnet_e81889 - altair processRandaoMixesReset 4.3400 us/op 8.4460 us/op 0.51
mainnet_e81889 - altair processHistoricalRootsUpdate 719.00 ns/op 817.00 ns/op 0.88
mainnet_e81889 - altair processParticipationFlagUpdates 3.0970 us/op 2.6960 us/op 1.15
mainnet_e81889 - altair processSyncCommitteeUpdates 569.00 ns/op 558.00 ns/op 1.02
mainnet_e81889 - altair afterProcessEpoch 131.52 ms/op 133.13 ms/op 0.99
phase0 processEpoch - mainnet_e58758 351.65 ms/op 388.09 ms/op 0.91
mainnet_e58758 - phase0 beforeProcessEpoch 144.19 ms/op 137.77 ms/op 1.05
mainnet_e58758 - phase0 processJustificationAndFinalization 17.783 us/op 18.568 us/op 0.96
mainnet_e58758 - phase0 processRewardsAndPenalties 64.289 ms/op 64.837 ms/op 0.99
mainnet_e58758 - phase0 processRegistryUpdates 8.1340 us/op 8.2620 us/op 0.98
mainnet_e58758 - phase0 processSlashings 519.00 ns/op 663.00 ns/op 0.78
mainnet_e58758 - phase0 processEth1DataReset 574.00 ns/op 454.00 ns/op 1.26
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.0258 ms/op 1.0474 ms/op 0.98
mainnet_e58758 - phase0 processSlashingsReset 4.2870 us/op 3.9300 us/op 1.09
mainnet_e58758 - phase0 processRandaoMixesReset 4.5670 us/op 4.5640 us/op 1.00
mainnet_e58758 - phase0 processHistoricalRootsUpdate 679.00 ns/op 596.00 ns/op 1.14
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.2700 us/op 3.9520 us/op 1.08
mainnet_e58758 - phase0 afterProcessEpoch 101.79 ms/op 99.746 ms/op 1.02
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2862 ms/op 1.2783 ms/op 1.01
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.6693 ms/op 1.4587 ms/op 1.14
altair processInactivityUpdates - 250000 normalcase 25.348 ms/op 30.635 ms/op 0.83
altair processInactivityUpdates - 250000 worstcase 29.255 ms/op 30.396 ms/op 0.96
phase0 processRegistryUpdates - 250000 normalcase 7.0770 us/op 8.4590 us/op 0.84
phase0 processRegistryUpdates - 250000 badcase_full_deposits 273.88 us/op 295.07 us/op 0.93
phase0 processRegistryUpdates - 250000 worstcase 0.5 131.49 ms/op 137.15 ms/op 0.96
altair processRewardsAndPenalties - 250000 normalcase 66.128 ms/op 68.413 ms/op 0.97
altair processRewardsAndPenalties - 250000 worstcase 70.699 ms/op 70.270 ms/op 1.01
phase0 getAttestationDeltas - 250000 normalcase 6.9585 ms/op 7.0490 ms/op 0.99
phase0 getAttestationDeltas - 250000 worstcase 6.8926 ms/op 6.7925 ms/op 1.01
phase0 processSlashings - 250000 worstcase 3.6803 ms/op 3.5600 ms/op 1.03
altair processSyncCommitteeUpdates - 250000 201.49 ms/op 188.58 ms/op 1.07
BeaconState.hashTreeRoot - No change 300.00 ns/op 349.00 ns/op 0.86
BeaconState.hashTreeRoot - 1 full validator 58.323 us/op 52.569 us/op 1.11
BeaconState.hashTreeRoot - 32 full validator 549.42 us/op 531.61 us/op 1.03
BeaconState.hashTreeRoot - 512 full validator 6.1220 ms/op 6.1838 ms/op 0.99
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 67.459 us/op 65.144 us/op 1.04
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 940.33 us/op 923.95 us/op 1.02
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 12.641 ms/op 14.418 ms/op 0.88
BeaconState.hashTreeRoot - 1 balances 49.248 us/op 50.318 us/op 0.98
BeaconState.hashTreeRoot - 32 balances 493.51 us/op 459.30 us/op 1.07
BeaconState.hashTreeRoot - 512 balances 4.8486 ms/op 4.7080 ms/op 1.03
BeaconState.hashTreeRoot - 250000 balances 81.276 ms/op 77.556 ms/op 1.05
aggregationBits - 2048 els - zipIndexesInBitList 17.324 us/op 17.896 us/op 0.97
regular array get 100000 times 44.821 us/op 45.585 us/op 0.98
wrappedArray get 100000 times 34.140 us/op 33.679 us/op 1.01
arrayWithProxy get 100000 times 17.153 ms/op 15.803 ms/op 1.09
ssz.Root.equals 621.00 ns/op 569.00 ns/op 1.09
byteArrayEquals 635.00 ns/op 562.00 ns/op 1.13
shuffle list - 16384 els 7.3239 ms/op 7.0960 ms/op 1.03
shuffle list - 250000 els 107.14 ms/op 104.55 ms/op 1.02
processSlot - 1 slots 9.8850 us/op 10.055 us/op 0.98
processSlot - 32 slots 1.4386 ms/op 1.4251 ms/op 1.01
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 215.36 us/op 212.68 us/op 1.01
getCommitteeAssignments - req 1 vs - 250000 vc 3.0102 ms/op 2.9730 ms/op 1.01
getCommitteeAssignments - req 100 vs - 250000 vc 4.2475 ms/op 4.2035 ms/op 1.01
getCommitteeAssignments - req 1000 vs - 250000 vc 4.6443 ms/op 4.6141 ms/op 1.01
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.2400 ns/op 4.8500 ns/op 1.08
state getBlockRootAtSlot - 250000 vs - 7PWei 948.94 ns/op 881.84 ns/op 1.08
computeProposers - vc 250000 11.770 ms/op 11.939 ms/op 0.99
computeEpochShuffling - vc 250000 111.45 ms/op 108.38 ms/op 1.03
getNextSyncCommittee - vc 250000 194.99 ms/op 189.45 ms/op 1.03

by benchmarkbot/action

@nflaig nflaig force-pushed the nflaig/release-comment-on-pr branch from a3bf02d to 2811c5e Compare March 6, 2023 13:01
@nflaig nflaig force-pushed the nflaig/release-comment-on-pr branch from 2811c5e to 9335dba Compare March 6, 2023 13:26
@nflaig nflaig force-pushed the nflaig/release-comment-on-pr branch from 9335dba to c12c7b2 Compare March 6, 2023 13:34
@nflaig nflaig enabled auto-merge (squash) March 6, 2023 13:48
@nflaig nflaig merged commit 0006d86 into unstable Mar 6, 2023
@nflaig nflaig deleted the nflaig/release-comment-on-pr branch March 6, 2023 13:58
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.6.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nflaig @wemeetagain