Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated logging framework in style guide #5370

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Remove outdated logging framework in style guide #5370

merged 1 commit into from
Apr 17, 2023

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Apr 17, 2023

Replaced by Logging policy section added in #5299

cc @dapplion

@nflaig
Remove outdated logging framework in style guide
21bf3ad 
Replaced by "Logging policy" section added in #5299
@nflaig nflaig requested a review from a team as a code owner April 17, 2023 18:19
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 6da4424 Previous: 6cfc518 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 726.13 us/op 588.10 us/op 1.23
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 47.631 us/op 57.554 us/op 0.83
BLS verify - blst-native 1.2355 ms/op 1.2550 ms/op 0.98
BLS verifyMultipleSignatures 3 - blst-native 2.5141 ms/op 2.6333 ms/op 0.95
BLS verifyMultipleSignatures 8 - blst-native 5.4171 ms/op 5.5760 ms/op 0.97
BLS verifyMultipleSignatures 32 - blst-native 19.625 ms/op 20.028 ms/op 0.98
BLS aggregatePubkeys 32 - blst-native 26.429 us/op 26.800 us/op 0.99
BLS aggregatePubkeys 128 - blst-native 101.80 us/op 103.89 us/op 0.98
getAttestationsForBlock 61.560 ms/op 64.627 ms/op 0.95
isKnown best case - 1 super set check 261.00 ns/op 266.00 ns/op 0.98
isKnown normal case - 2 super set checks 257.00 ns/op 253.00 ns/op 1.02
isKnown worse case - 16 super set checks 258.00 ns/op 253.00 ns/op 1.02
CheckpointStateCache - add get delete 5.3700 us/op 5.8380 us/op 0.92
validate gossip signedAggregateAndProof - struct 2.9218 ms/op 2.8421 ms/op 1.03
validate gossip attestation - struct 1.3638 ms/op 1.3603 ms/op 1.00
pickEth1Vote - no votes 1.3952 ms/op 1.4011 ms/op 1.00
pickEth1Vote - max votes 10.641 ms/op 13.659 ms/op 0.78
pickEth1Vote - Eth1Data hashTreeRoot value x2048 9.3679 ms/op 10.047 ms/op 0.93
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 14.705 ms/op 17.827 ms/op 0.82
pickEth1Vote - Eth1Data fastSerialize value x2048 780.57 us/op 719.20 us/op 1.09
pickEth1Vote - Eth1Data fastSerialize tree x2048 9.0262 ms/op 6.7498 ms/op 1.34
bytes32 toHexString 660.00 ns/op 573.00 ns/op 1.15
bytes32 Buffer.toString(hex) 433.00 ns/op 420.00 ns/op 1.03
bytes32 Buffer.toString(hex) from Uint8Array 632.00 ns/op 634.00 ns/op 1.00
bytes32 Buffer.toString(hex) + 0x 436.00 ns/op 424.00 ns/op 1.03
Object access 1 prop 0.18800 ns/op 0.20300 ns/op 0.93
Map access 1 prop 0.16700 ns/op 0.17100 ns/op 0.98
Object get x1000 7.6310 ns/op 6.9900 ns/op 1.09
Map get x1000 0.64900 ns/op 0.68000 ns/op 0.95
Object set x1000 63.156 ns/op 70.969 ns/op 0.89
Map set x1000 49.299 ns/op 57.746 ns/op 0.85
Return object 10000 times 0.24860 ns/op 0.25670 ns/op 0.97
Throw Error 10000 times 4.3397 us/op 4.5388 us/op 0.96
fastMsgIdFn sha256 / 200 bytes 3.6050 us/op 3.6430 us/op 0.99
fastMsgIdFn h32 xxhash / 200 bytes 312.00 ns/op 333.00 ns/op 0.94
fastMsgIdFn h64 xxhash / 200 bytes 457.00 ns/op 490.00 ns/op 0.93
fastMsgIdFn sha256 / 1000 bytes 11.997 us/op 12.014 us/op 1.00
fastMsgIdFn h32 xxhash / 1000 bytes 447.00 ns/op 457.00 ns/op 0.98
fastMsgIdFn h64 xxhash / 1000 bytes 511.00 ns/op 571.00 ns/op 0.89
fastMsgIdFn sha256 / 10000 bytes 106.01 us/op 106.40 us/op 1.00
fastMsgIdFn h32 xxhash / 10000 bytes 2.0360 us/op 2.0260 us/op 1.00
fastMsgIdFn h64 xxhash / 10000 bytes 1.4790 us/op 1.4780 us/op 1.00
enrSubnets - fastDeserialize 64 bits 1.3970 us/op 2.1020 us/op 0.66
enrSubnets - ssz BitVector 64 bits 626.00 ns/op 646.00 ns/op 0.97
enrSubnets - fastDeserialize 4 bits 200.00 ns/op 228.00 ns/op 0.88
enrSubnets - ssz BitVector 4 bits 647.00 ns/op 617.00 ns/op 1.05
prioritizePeers score -10:0 att 32-0.1 sync 2-0 121.55 us/op 109.45 us/op 1.11
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 154.71 us/op 160.61 us/op 0.96
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 189.16 us/op 194.26 us/op 0.97
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 361.33 us/op 362.52 us/op 1.00
prioritizePeers score 0:0 att 64-1 sync 4-1 423.82 us/op 431.66 us/op 0.98
array of 16000 items push then shift 1.6988 us/op 1.6673 us/op 1.02
LinkedList of 16000 items push then shift 9.3440 ns/op 9.1220 ns/op 1.02
array of 16000 items push then pop 117.77 ns/op 116.50 ns/op 1.01
LinkedList of 16000 items push then pop 9.3240 ns/op 9.1650 ns/op 1.02
array of 24000 items push then shift 2.4304 us/op 2.4345 us/op 1.00
LinkedList of 24000 items push then shift 9.6160 ns/op 10.054 ns/op 0.96
array of 24000 items push then pop 90.077 ns/op 91.838 ns/op 0.98
LinkedList of 24000 items push then pop 8.8910 ns/op 9.1910 ns/op 0.97
intersect bitArray bitLen 8 14.133 ns/op 14.022 ns/op 1.01
intersect array and set length 8 92.120 ns/op 108.51 ns/op 0.85
intersect bitArray bitLen 128 46.781 ns/op 45.837 ns/op 1.02
intersect array and set length 128 1.2958 us/op 1.3343 us/op 0.97
Buffer.concat 32 items 3.1420 us/op 2.8670 us/op 1.10
Uint8Array.set 32 items 3.1130 us/op 2.8520 us/op 1.09
pass gossip attestations to forkchoice per slot 3.5361 ms/op 3.1268 ms/op 1.13
computeDeltas 3.1478 ms/op 3.1013 ms/op 1.01
computeProposerBoostScoreFromBalances 1.8786 ms/op 1.7946 ms/op 1.05
altair processAttestation - 250000 vs - 7PWei normalcase 2.8331 ms/op 2.6645 ms/op 1.06
altair processAttestation - 250000 vs - 7PWei worstcase 4.1963 ms/op 3.9279 ms/op 1.07
altair processAttestation - setStatus - 1/6 committees join 148.30 us/op 148.03 us/op 1.00
altair processAttestation - setStatus - 1/3 committees join 288.57 us/op 287.60 us/op 1.00
altair processAttestation - setStatus - 1/2 committees join 393.42 us/op 375.49 us/op 1.05
altair processAttestation - setStatus - 2/3 committees join 494.19 us/op 502.97 us/op 0.98
altair processAttestation - setStatus - 4/5 committees join 678.21 us/op 666.44 us/op 1.02
altair processAttestation - setStatus - 100% committees join 791.01 us/op 784.82 us/op 1.01
altair processBlock - 250000 vs - 7PWei normalcase 17.522 ms/op 21.596 ms/op 0.81
altair processBlock - 250000 vs - 7PWei normalcase hashState 26.888 ms/op 26.584 ms/op 1.01
altair processBlock - 250000 vs - 7PWei worstcase 52.371 ms/op 64.654 ms/op 0.81
altair processBlock - 250000 vs - 7PWei worstcase hashState 70.270 ms/op 75.738 ms/op 0.93
phase0 processBlock - 250000 vs - 7PWei normalcase 2.2446 ms/op 2.3285 ms/op 0.96
phase0 processBlock - 250000 vs - 7PWei worstcase 31.083 ms/op 31.356 ms/op 0.99
altair processEth1Data - 250000 vs - 7PWei normalcase 520.87 us/op 568.08 us/op 0.92
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 8.0500 us/op 8.5350 us/op 0.94
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 27.045 us/op 25.307 us/op 1.07
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 11.145 us/op 9.9150 us/op 1.12
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 8.1000 us/op 8.1610 us/op 0.99
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 104.89 us/op 121.41 us/op 0.86
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 680.88 us/op 935.46 us/op 0.73
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 903.40 us/op 1.4201 ms/op 0.64
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 900.20 us/op 1.2469 ms/op 0.72
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 2.4680 ms/op 2.3634 ms/op 1.04
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 1.5061 ms/op 2.0265 ms/op 0.74
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 4.1123 ms/op 3.8483 ms/op 1.07
Tree 40 250000 create 334.37 ms/op 299.73 ms/op 1.12
Tree 40 250000 get(125000) 200.79 ns/op 180.39 ns/op 1.11
Tree 40 250000 set(125000) 1.0738 us/op 928.60 ns/op 1.16
Tree 40 250000 toArray() 24.247 ms/op 22.041 ms/op 1.10
Tree 40 250000 iterate all - toArray() + loop 25.753 ms/op 20.065 ms/op 1.28
Tree 40 250000 iterate all - get(i) 79.193 ms/op 71.966 ms/op 1.10
MutableVector 250000 create 11.741 ms/op 12.655 ms/op 0.93
MutableVector 250000 get(125000) 6.6320 ns/op 6.4550 ns/op 1.03
MutableVector 250000 set(125000) 279.79 ns/op 263.14 ns/op 1.06
MutableVector 250000 toArray() 3.1529 ms/op 3.1477 ms/op 1.00
MutableVector 250000 iterate all - toArray() + loop 3.6499 ms/op 3.1071 ms/op 1.17
MutableVector 250000 iterate all - get(i) 1.5275 ms/op 1.5255 ms/op 1.00
Array 250000 create 2.9459 ms/op 2.7640 ms/op 1.07
Array 250000 clone - spread 1.1342 ms/op 1.2825 ms/op 0.88
Array 250000 get(125000) 0.53000 ns/op 0.63700 ns/op 0.83
Array 250000 set(125000) 0.61000 ns/op 0.68800 ns/op 0.89
Array 250000 iterate all - loop 112.19 us/op 84.522 us/op 1.33
effectiveBalanceIncrements clone Uint8Array 300000 27.498 us/op 35.625 us/op 0.77
effectiveBalanceIncrements clone MutableVector 300000 329.00 ns/op 406.00 ns/op 0.81
effectiveBalanceIncrements rw all Uint8Array 300000 168.66 us/op 171.24 us/op 0.98
effectiveBalanceIncrements rw all MutableVector 300000 85.006 ms/op 86.905 ms/op 0.98
phase0 afterProcessEpoch - 250000 vs - 7PWei 116.61 ms/op 117.88 ms/op 0.99
phase0 beforeProcessEpoch - 250000 vs - 7PWei 35.178 ms/op 36.968 ms/op 0.95
altair processEpoch - mainnet_e81889 315.54 ms/op 361.63 ms/op 0.87
mainnet_e81889 - altair beforeProcessEpoch 69.464 ms/op 70.147 ms/op 0.99
mainnet_e81889 - altair processJustificationAndFinalization 20.974 us/op 20.472 us/op 1.02
mainnet_e81889 - altair processInactivityUpdates 6.4009 ms/op 6.5388 ms/op 0.98
mainnet_e81889 - altair processRewardsAndPenalties 57.316 ms/op 78.216 ms/op 0.73
mainnet_e81889 - altair processRegistryUpdates 3.0830 us/op 3.0620 us/op 1.01
mainnet_e81889 - altair processSlashings 634.00 ns/op 489.00 ns/op 1.30
mainnet_e81889 - altair processEth1DataReset 647.00 ns/op 915.00 ns/op 0.71
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.3402 ms/op 1.6560 ms/op 0.81
mainnet_e81889 - altair processSlashingsReset 5.3760 us/op 6.1650 us/op 0.87
mainnet_e81889 - altair processRandaoMixesReset 8.5800 us/op 12.754 us/op 0.67
mainnet_e81889 - altair processHistoricalRootsUpdate 1.0110 us/op 1.1250 us/op 0.90
mainnet_e81889 - altair processParticipationFlagUpdates 2.1980 us/op 5.2120 us/op 0.42
mainnet_e81889 - altair processSyncCommitteeUpdates 900.00 ns/op 776.00 ns/op 1.16
mainnet_e81889 - altair afterProcessEpoch 137.98 ms/op 130.94 ms/op 1.05
phase0 processEpoch - mainnet_e58758 390.90 ms/op 412.66 ms/op 0.95
mainnet_e58758 - phase0 beforeProcessEpoch 153.53 ms/op 150.56 ms/op 1.02
mainnet_e58758 - phase0 processJustificationAndFinalization 29.689 us/op 22.186 us/op 1.34
mainnet_e58758 - phase0 processRewardsAndPenalties 65.531 ms/op 73.692 ms/op 0.89
mainnet_e58758 - phase0 processRegistryUpdates 7.5940 us/op 13.257 us/op 0.57
mainnet_e58758 - phase0 processSlashings 547.00 ns/op 971.00 ns/op 0.56
mainnet_e58758 - phase0 processEth1DataReset 577.00 ns/op 922.00 ns/op 0.63
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.0588 ms/op 1.2487 ms/op 0.85
mainnet_e58758 - phase0 processSlashingsReset 3.4310 us/op 6.5030 us/op 0.53
mainnet_e58758 - phase0 processRandaoMixesReset 4.4920 us/op 8.1920 us/op 0.55
mainnet_e58758 - phase0 processHistoricalRootsUpdate 595.00 ns/op 1.2800 us/op 0.46
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.0590 us/op 7.0520 us/op 0.58
mainnet_e58758 - phase0 afterProcessEpoch 99.106 ms/op 105.38 ms/op 0.94
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2333 ms/op 1.2952 ms/op 0.95
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4795 ms/op 1.9794 ms/op 0.75
altair processInactivityUpdates - 250000 normalcase 24.853 ms/op 32.037 ms/op 0.78
altair processInactivityUpdates - 250000 worstcase 26.333 ms/op 30.605 ms/op 0.86
phase0 processRegistryUpdates - 250000 normalcase 6.7440 us/op 12.312 us/op 0.55
phase0 processRegistryUpdates - 250000 badcase_full_deposits 275.41 us/op 424.08 us/op 0.65
phase0 processRegistryUpdates - 250000 worstcase 0.5 134.08 ms/op 152.19 ms/op 0.88
altair processRewardsAndPenalties - 250000 normalcase 67.921 ms/op 73.849 ms/op 0.92
altair processRewardsAndPenalties - 250000 worstcase 70.511 ms/op 79.607 ms/op 0.89
phase0 getAttestationDeltas - 250000 normalcase 7.2467 ms/op 8.4380 ms/op 0.86
phase0 getAttestationDeltas - 250000 worstcase 6.6390 ms/op 7.2428 ms/op 0.92
phase0 processSlashings - 250000 worstcase 3.6294 ms/op 4.0302 ms/op 0.90
altair processSyncCommitteeUpdates - 250000 175.83 ms/op 202.64 ms/op 0.87
BeaconState.hashTreeRoot - No change 347.00 ns/op 284.00 ns/op 1.22
BeaconState.hashTreeRoot - 1 full validator 52.244 us/op 57.736 us/op 0.90
BeaconState.hashTreeRoot - 32 full validator 502.95 us/op 616.84 us/op 0.82
BeaconState.hashTreeRoot - 512 full validator 5.8240 ms/op 6.4739 ms/op 0.90
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 63.639 us/op 72.550 us/op 0.88
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.0462 ms/op 1.0320 ms/op 1.01
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 12.854 ms/op 12.818 ms/op 1.00
BeaconState.hashTreeRoot - 1 balances 51.409 us/op 55.588 us/op 0.92
BeaconState.hashTreeRoot - 32 balances 496.04 us/op 501.83 us/op 0.99
BeaconState.hashTreeRoot - 512 balances 4.8802 ms/op 5.0688 ms/op 0.96
BeaconState.hashTreeRoot - 250000 balances 76.378 ms/op 82.588 ms/op 0.92
aggregationBits - 2048 els - zipIndexesInBitList 18.121 us/op 19.369 us/op 0.94
regular array get 100000 times 33.573 us/op 34.573 us/op 0.97
wrappedArray get 100000 times 33.688 us/op 34.100 us/op 0.99
arrayWithProxy get 100000 times 18.142 ms/op 16.418 ms/op 1.10
ssz.Root.equals 575.00 ns/op 1.0140 us/op 0.57
byteArrayEquals 576.00 ns/op 996.00 ns/op 0.58
shuffle list - 16384 els 7.1161 ms/op 7.1184 ms/op 1.00
shuffle list - 250000 els 104.13 ms/op 104.82 ms/op 0.99
processSlot - 1 slots 9.5940 us/op 9.1390 us/op 1.05
processSlot - 32 slots 1.4364 ms/op 1.4387 ms/op 1.00
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 36.823 ms/op 42.949 ms/op 0.86
getCommitteeAssignments - req 1 vs - 250000 vc 2.9141 ms/op 3.2493 ms/op 0.90
getCommitteeAssignments - req 100 vs - 250000 vc 4.1433 ms/op 4.5215 ms/op 0.92
getCommitteeAssignments - req 1000 vs - 250000 vc 4.4820 ms/op 4.9540 ms/op 0.90
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.6800 ns/op 5.3900 ns/op 0.87
state getBlockRootAtSlot - 250000 vs - 7PWei 906.48 ns/op 1.3087 us/op 0.69
computeProposers - vc 250000 9.9856 ms/op 13.020 ms/op 0.77
computeEpochShuffling - vc 250000 96.408 ms/op 119.57 ms/op 0.81
getNextSyncCommittee - vc 250000 172.25 ms/op 211.54 ms/op 0.81
computeSigningRoot for AttestationData 12.888 us/op 15.941 us/op 0.81
hash AttestationData serialized data then Buffer.toString(base64) 2.2861 us/op 2.7482 us/op 0.83
toHexString serialized data 1.0180 us/op 1.4361 us/op 0.71
Buffer.toString(base64) 318.30 ns/op 378.61 ns/op 0.84

by benchmarkbot/action

wemeetagain
wemeetagain approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@wemeetagain wemeetagain merged commit 3ee1d8a into unstable Apr 17, 2023
@wemeetagain wemeetagain deleted the nflaig/remove-logging-framework branch April 17, 2023 21:01
@dapplion
Copy link
Contributor

Oh lol im blind, thanks for picking it up

@wemeetagain
Copy link
Member

🎉 This PR is included in v1.8.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nflaig @dapplion @wemeetagain