-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: cleanup deneb types and use max blob commitments per block for deneb containers #5929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for deneb containers
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
previously approved these changes
Sep 2, 2023
This was referenced Sep 3, 2023
Closed
twoeths
approved these changes
Sep 4, 2023
wemeetagain
approved these changes
Sep 4, 2023
🎉 This PR is included in v1.12.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAX_BLOB_COMMITMENTS_PER_BLOCK
instead ofMAX_BLOBS_PER_BLOCK
ref: see RFC: UseMAX_BLOB_COMMITMENTS_PER_BLOCK
as max length for BlindedBlobsBundle SSZ lists ethereum/builder-specs#87 (its for builder types but also applies for all all list objects related to blobs)