-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove not yet relevant prover options #6440
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeluard
force-pushed
the
jeluard/prover-remove-beaconbootnodes
branch
2 times, most recently
from
February 16, 2024 13:56
a9e0313
to
81fd4e6
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6440 +/- ##
=========================================
Coverage 61.70% 61.70%
=========================================
Files 553 553
Lines 57858 57858
Branches 1829 1829
=========================================
Hits 35702 35702
Misses 22119 22119
Partials 37 37 |
jeluard
force-pushed
the
jeluard/prover-remove-beaconbootnodes
branch
from
February 16, 2024 14:13
81fd4e6
to
39f2648
Compare
jeluard
force-pushed
the
jeluard/prover-remove-beaconbootnodes
branch
from
February 16, 2024 14:55
39f2648
to
9913d5f
Compare
nazarhussain
approved these changes
Feb 16, 2024
nflaig
changed the title
chore: remove not yet relevant option
chore: remove not yet relevant prover options
Feb 16, 2024
nflaig
approved these changes
Feb 16, 2024
Performance Report✔️ no performance regression detected Full benchmark results
|
🎉 This PR is included in v1.16.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make sure
prover
CLI does not expose options not yet implemented.Description
The
beaconBootnodes
option should not be exposed by theprover
CLI as it's not yet implemented.