-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use snappy-wasm #6483
base: unstable
Are you sure you want to change the base?
feat: use snappy-wasm #6483
Conversation
Benchmarks show `snappy` is faster at compressing and uncompressing larger payloads than `snappyjs`.
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #6483 +/- ##
============================================
- Coverage 48.51% 48.51% -0.01%
============================================
Files 600 600
Lines 40142 40150 +8
Branches 2057 2058 +1
============================================
+ Hits 19475 19477 +2
- Misses 20629 20635 +6
Partials 38 38 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM! 🚀
Just the tiny question on the perf output but not something I feel strongly about. Truth be told we wont be looking at them much once this is merged. Neurosis is strong with this one... 😆 ... sigh....
Grafana is not wanting to load. Will click the approve once I can post some metrics here
import {itBench} from "@dapplion/benchmark"; | ||
|
||
describe("network / gossip / snappy", () => { | ||
const msgLens = [100, 200, 300, 400, 500, 1000, 10000, 100000]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used to see blocks with 2MB, need to add 2MB, 5MB and 10MB (max size of gossip message) message length
the optimization is in |
looks like the metrics may not be panning out for this branch. It doesnt seem like there is a notable performance gain and the memory consumption is way up. Also seems a bit less stable with RSS bouncing around a lot on longer timeframes.
|
Just noting based on standup today that we will need to deploy via Docker for testing this one. |
A new contender has emerged (two years ago) Refreshed this branch and the benchmark results, check the description Also redeployed to feat3 |
Motivation
Benchmarks show
snappy-wasm
is faster at compressing and uncompressing thansnappyjs
.Description
snappy-wasm
for compressing / uncompressing gossip payloadssnappy
vssnappyjs
vssnappy-wasm
benchmarksTODO
Closes #4170