Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow to configure keymanager token file path #6525

Merged
merged 3 commits into from
Mar 25, 2024
Merged

feat: allow to configure keymanager token file path #6525

merged 3 commits into from
Mar 25, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Mar 8, 2024 •
edited
Loading

Motivation

Description

Allow to configure keymanager token file path via --keymanager.tokenFile /path/to/file CLI flag

nflaig
nflaig commented Mar 8, 2024
View reviewed changes
packages/cli/src/cmds/validator/options.ts
@@ -93,12 +94,18 @@ export const keymanagerOptions: CliCommandOptions<KeymanagerArgs> = {
default: false,
group: "keymanager",
},
"keymanager.authEnabled": {
"keymanager.auth": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the flag to enable authentication to be more inline with other existing boolean flags

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth documenting in next release, so that people can migrate to the preferred syntax?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to migrate, existing setups can keep previous value

@nflaig nflaig marked this pull request as ready for review March 8, 2024 17:41
@nflaig nflaig requested a review from a team as a code owner March 8, 2024 17:41
@codecov Codecov
Copy link

codecov bot commented Mar 8, 2024 •
edited
Loading

Codecov Report

Merging #6525 (a273bd8) into unstable (533a08e) will not change coverage.
Report is 1 commits behind head on unstable.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff            @@
##           unstable    #6525   +/-   ##
=========================================
  Coverage     61.49%   61.49%           
=========================================
  Files           556      556           
  Lines         58895    58895           
  Branches       1856     1856           
=========================================
  Hits          36216    36216           
  Misses        22638    22638           
  Partials         41       41

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: e403a1c Previous: 533a08e Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 416.33 us/op 614.90 us/op 0.68
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 54.767 us/op 116.71 us/op 0.47
BLS verify - blst-native 1.1718 ms/op 1.3420 ms/op 0.87
BLS verifyMultipleSignatures 3 - blst-native 2.4525 ms/op 2.8128 ms/op 0.87
BLS verifyMultipleSignatures 8 - blst-native 5.4675 ms/op 6.2675 ms/op 0.87
BLS verifyMultipleSignatures 32 - blst-native 19.974 ms/op 23.249 ms/op 0.86
BLS verifyMultipleSignatures 64 - blst-native 39.911 ms/op 45.615 ms/op 0.87
BLS verifyMultipleSignatures 128 - blst-native 81.926 ms/op 90.509 ms/op 0.91
BLS deserializing 10000 signatures 849.39 ms/op 989.51 ms/op 0.86
BLS deserializing 100000 signatures 8.7057 s/op 9.4209 s/op 0.92
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.2190 ms/op 1.4966 ms/op 0.81
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.3653 ms/op 1.6508 ms/op 0.83
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.6513 ms/op 2.5647 ms/op 1.03
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.8165 ms/op 3.6339 ms/op 1.05
BLS verifyMultipleSignatures - same message - 128 - blst-native 7.5816 ms/op 6.7726 ms/op 1.12
BLS aggregatePubkeys 32 - blst-native 23.435 us/op 30.074 us/op 0.78
BLS aggregatePubkeys 128 - blst-native 92.504 us/op 116.61 us/op 0.79
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 53.686 ms/op 87.551 ms/op 0.61
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 55.448 ms/op 82.862 ms/op 0.67
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 25.769 ms/op 65.150 ms/op 0.40
getSlashingsAndExits - default max 111.73 us/op 269.98 us/op 0.41
getSlashingsAndExits - 2k 370.56 us/op 494.96 us/op 0.75
proposeBlockBody type=full, size=empty 4.7873 ms/op 6.9319 ms/op 0.69
isKnown best case - 1 super set check 332.00 ns/op 579.00 ns/op 0.57
isKnown normal case - 2 super set checks 333.00 ns/op 555.00 ns/op 0.60
isKnown worse case - 16 super set checks 332.00 ns/op 515.00 ns/op 0.64
CheckpointStateCache - add get delete 4.5570 us/op 7.2510 us/op 0.63
validate api signedAggregateAndProof - struct 2.5086 ms/op 2.8002 ms/op 0.90
validate gossip signedAggregateAndProof - struct 2.4566 ms/op 2.7994 ms/op 0.88
validate gossip attestation - vc 640000 1.1428 ms/op 1.3765 ms/op 0.83
batch validate gossip attestation - vc 640000 - chunk 32 140.97 us/op 170.09 us/op 0.83
batch validate gossip attestation - vc 640000 - chunk 64 128.16 us/op 146.74 us/op 0.87
batch validate gossip attestation - vc 640000 - chunk 128 121.84 us/op 137.72 us/op 0.88
batch validate gossip attestation - vc 640000 - chunk 256 122.83 us/op 128.51 us/op 0.96
pickEth1Vote - no votes 981.14 us/op 1.2408 ms/op 0.79
pickEth1Vote - max votes 13.475 ms/op 9.6801 ms/op 1.39
pickEth1Vote - Eth1Data hashTreeRoot value x2048 24.670 ms/op 21.169 ms/op 1.17
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 33.796 ms/op 32.599 ms/op 1.04
pickEth1Vote - Eth1Data fastSerialize value x2048 529.89 us/op 639.49 us/op 0.83
pickEth1Vote - Eth1Data fastSerialize tree x2048 9.0538 ms/op 6.4774 ms/op 1.40
bytes32 toHexString 541.00 ns/op 491.00 ns/op 1.10
bytes32 Buffer.toString(hex) 376.00 ns/op 294.00 ns/op 1.28
bytes32 Buffer.toString(hex) from Uint8Array 533.00 ns/op 424.00 ns/op 1.26
bytes32 Buffer.toString(hex) + 0x 339.00 ns/op 292.00 ns/op 1.16
Object access 1 prop 0.22400 ns/op 0.15600 ns/op 1.44
Map access 1 prop 0.20100 ns/op 0.14500 ns/op 1.39
Object get x1000 5.6310 ns/op 7.1150 ns/op 0.79
Map get x1000 0.81200 ns/op 0.74400 ns/op 1.09
Object set x1000 26.208 ns/op 49.653 ns/op 0.53
Map set x1000 18.274 ns/op 39.171 ns/op 0.47
Return object 10000 times 0.24250 ns/op 0.23530 ns/op 1.03
Throw Error 10000 times 2.8564 us/op 3.8798 us/op 0.74
fastMsgIdFn sha256 / 200 bytes 2.1210 us/op 3.2520 us/op 0.65
fastMsgIdFn h32 xxhash / 200 bytes 331.00 ns/op 270.00 ns/op 1.23
fastMsgIdFn h64 xxhash / 200 bytes 376.00 ns/op 360.00 ns/op 1.04
fastMsgIdFn sha256 / 1000 bytes 6.2900 us/op 11.500 us/op 0.55
fastMsgIdFn h32 xxhash / 1000 bytes 449.00 ns/op 403.00 ns/op 1.11
fastMsgIdFn h64 xxhash / 1000 bytes 432.00 ns/op 432.00 ns/op 1.00
fastMsgIdFn sha256 / 10000 bytes 54.543 us/op 102.20 us/op 0.53
fastMsgIdFn h32 xxhash / 10000 bytes 1.9480 us/op 1.8580 us/op 1.05
fastMsgIdFn h64 xxhash / 10000 bytes 1.3210 us/op 1.2930 us/op 1.02
send data - 1000 256B messages 13.015 ms/op 19.011 ms/op 0.68
send data - 1000 512B messages 19.866 ms/op 25.365 ms/op 0.78
send data - 1000 1024B messages 27.081 ms/op 38.161 ms/op 0.71
send data - 1000 1200B messages 32.798 ms/op 38.789 ms/op 0.85
send data - 1000 2048B messages 42.044 ms/op 47.780 ms/op 0.88
send data - 1000 4096B messages 36.671 ms/op 43.152 ms/op 0.85
send data - 1000 16384B messages 112.50 ms/op 116.71 ms/op 0.96
send data - 1000 65536B messages 376.90 ms/op 485.88 ms/op 0.78
enrSubnets - fastDeserialize 64 bits 1.4390 us/op 1.2820 us/op 1.12
enrSubnets - ssz BitVector 64 bits 608.00 ns/op 419.00 ns/op 1.45
enrSubnets - fastDeserialize 4 bits 268.00 ns/op 174.00 ns/op 1.54
enrSubnets - ssz BitVector 4 bits 528.00 ns/op 424.00 ns/op 1.25
prioritizePeers score -10:0 att 32-0.1 sync 2-0 87.505 us/op 113.54 us/op 0.77
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 110.89 us/op 123.85 us/op 0.90
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 181.24 us/op 161.64 us/op 1.12
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 291.65 us/op 288.73 us/op 1.01
prioritizePeers score 0:0 att 64-1 sync 4-1 285.78 us/op 339.79 us/op 0.84
array of 16000 items push then shift 1.3586 us/op 1.6449 us/op 0.83
LinkedList of 16000 items push then shift 8.3730 ns/op 8.7260 ns/op 0.96
array of 16000 items push then pop 118.84 ns/op 90.957 ns/op 1.31
LinkedList of 16000 items push then pop 7.0760 ns/op 8.2720 ns/op 0.86
array of 24000 items push then shift 2.1658 us/op 2.3065 us/op 0.94
LinkedList of 24000 items push then shift 6.6210 ns/op 9.0890 ns/op 0.73
array of 24000 items push then pop 160.09 ns/op 104.24 ns/op 1.54
LinkedList of 24000 items push then pop 9.7510 ns/op 8.6120 ns/op 1.13
intersect bitArray bitLen 8 5.2200 ns/op 5.8450 ns/op 0.89
intersect array and set length 8 89.243 ns/op 63.411 ns/op 1.41
intersect bitArray bitLen 128 29.896 ns/op 35.480 ns/op 0.84
intersect array and set length 128 856.67 ns/op 868.33 ns/op 0.99
bitArray.getTrueBitIndexes() bitLen 128 1.7620 us/op 1.4670 us/op 1.20
bitArray.getTrueBitIndexes() bitLen 248 3.3560 us/op 2.5100 us/op 1.34
bitArray.getTrueBitIndexes() bitLen 512 5.6680 us/op 4.9090 us/op 1.15
Buffer.concat 32 items 1.1580 us/op 1.0540 us/op 1.10
Uint8Array.set 32 items 2.0460 us/op 2.0940 us/op 0.98
Set add up to 64 items then delete first 1.8334 us/op 4.4153 us/op 0.42
OrderedSet add up to 64 items then delete first 2.7826 us/op 5.4880 us/op 0.51
Set add up to 64 items then delete last 2.1011 us/op 4.6593 us/op 0.45
OrderedSet add up to 64 items then delete last 3.1365 us/op 5.7915 us/op 0.54
Set add up to 64 items then delete middle 2.2601 us/op 4.6112 us/op 0.49
OrderedSet add up to 64 items then delete middle 5.7922 us/op 7.0444 us/op 0.82
Set add up to 128 items then delete first 5.8723 us/op 9.3523 us/op 0.63
OrderedSet add up to 128 items then delete first 8.5942 us/op 12.386 us/op 0.69
Set add up to 128 items then delete last 4.2465 us/op 9.1673 us/op 0.46
OrderedSet add up to 128 items then delete last 8.5714 us/op 11.649 us/op 0.74
Set add up to 128 items then delete middle 5.3144 us/op 9.0924 us/op 0.58
OrderedSet add up to 128 items then delete middle 14.332 us/op 16.836 us/op 0.85
Set add up to 256 items then delete first 11.934 us/op 18.795 us/op 0.63
OrderedSet add up to 256 items then delete first 19.625 us/op 25.115 us/op 0.78
Set add up to 256 items then delete last 10.257 us/op 18.062 us/op 0.57
OrderedSet add up to 256 items then delete last 15.520 us/op 22.986 us/op 0.68
Set add up to 256 items then delete middle 10.618 us/op 18.146 us/op 0.59
OrderedSet add up to 256 items then delete middle 37.753 us/op 44.666 us/op 0.85
transfer serialized Status (84 B) 1.8290 us/op 1.7070 us/op 1.07
copy serialized Status (84 B) 1.3110 us/op 1.3470 us/op 0.97
transfer serialized SignedVoluntaryExit (112 B) 2.0690 us/op 1.8970 us/op 1.09
copy serialized SignedVoluntaryExit (112 B) 1.5050 us/op 1.5370 us/op 0.98
transfer serialized ProposerSlashing (416 B) 2.5610 us/op 3.0480 us/op 0.84
copy serialized ProposerSlashing (416 B) 2.4740 us/op 3.0370 us/op 0.81
transfer serialized Attestation (485 B) 2.5850 us/op 3.2550 us/op 0.79
copy serialized Attestation (485 B) 2.3550 us/op 3.0260 us/op 0.78
transfer serialized AttesterSlashing (33232 B) 2.7240 us/op 3.0680 us/op 0.89
copy serialized AttesterSlashing (33232 B) 10.193 us/op 6.3570 us/op 1.60
transfer serialized Small SignedBeaconBlock (128000 B) 2.7110 us/op 3.3480 us/op 0.81
copy serialized Small SignedBeaconBlock (128000 B) 27.076 us/op 14.362 us/op 1.89
transfer serialized Avg SignedBeaconBlock (200000 B) 2.8670 us/op 3.3780 us/op 0.85
copy serialized Avg SignedBeaconBlock (200000 B) 39.991 us/op 20.512 us/op 1.95
transfer serialized BlobsSidecar (524380 B) 3.6330 us/op 3.1260 us/op 1.16
copy serialized BlobsSidecar (524380 B) 128.45 us/op 83.160 us/op 1.54
transfer serialized Big SignedBeaconBlock (1000000 B) 3.5280 us/op 3.0820 us/op 1.14
copy serialized Big SignedBeaconBlock (1000000 B) 389.63 us/op 172.97 us/op 2.25
pass gossip attestations to forkchoice per slot 3.1343 ms/op 3.8293 ms/op 0.82
forkChoice updateHead vc 100000 bc 64 eq 0 458.16 us/op 701.10 us/op 0.65
forkChoice updateHead vc 600000 bc 64 eq 0 3.2562 ms/op 4.6326 ms/op 0.70
forkChoice updateHead vc 1000000 bc 64 eq 0 4.5585 ms/op 7.1716 ms/op 0.64
forkChoice updateHead vc 600000 bc 320 eq 0 2.8373 ms/op 4.1573 ms/op 0.68
forkChoice updateHead vc 600000 bc 1200 eq 0 3.0420 ms/op 4.2271 ms/op 0.72
forkChoice updateHead vc 600000 bc 7200 eq 0 3.7231 ms/op 5.4059 ms/op 0.69
forkChoice updateHead vc 600000 bc 64 eq 1000 10.940 ms/op 11.596 ms/op 0.94
forkChoice updateHead vc 600000 bc 64 eq 10000 10.681 ms/op 11.956 ms/op 0.89
forkChoice updateHead vc 600000 bc 64 eq 300000 15.214 ms/op 16.046 ms/op 0.95
computeDeltas 500000 validators 300 proto nodes 3.6025 ms/op 6.7390 ms/op 0.53
computeDeltas 500000 validators 1200 proto nodes 3.2786 ms/op 6.5555 ms/op 0.50
computeDeltas 500000 validators 7200 proto nodes 2.9974 ms/op 6.7188 ms/op 0.45
computeDeltas 750000 validators 300 proto nodes 4.6375 ms/op 9.9000 ms/op 0.47
computeDeltas 750000 validators 1200 proto nodes 4.6767 ms/op 9.9584 ms/op 0.47
computeDeltas 750000 validators 7200 proto nodes 4.6540 ms/op 9.8460 ms/op 0.47
computeDeltas 1400000 validators 300 proto nodes 9.9947 ms/op 19.186 ms/op 0.52
computeDeltas 1400000 validators 1200 proto nodes 10.837 ms/op 19.440 ms/op 0.56
computeDeltas 1400000 validators 7200 proto nodes 11.062 ms/op 19.616 ms/op 0.56
computeDeltas 2100000 validators 300 proto nodes 13.243 ms/op 29.169 ms/op 0.45
computeDeltas 2100000 validators 1200 proto nodes 14.216 ms/op 28.344 ms/op 0.50
computeDeltas 2100000 validators 7200 proto nodes 15.007 ms/op 30.378 ms/op 0.49
altair processAttestation - 250000 vs - 7PWei normalcase 1.7619 ms/op 2.2985 ms/op 0.77
altair processAttestation - 250000 vs - 7PWei worstcase 3.1457 ms/op 3.6419 ms/op 0.86
altair processAttestation - setStatus - 1/6 committees join 113.08 us/op 185.02 us/op 0.61
altair processAttestation - setStatus - 1/3 committees join 217.45 us/op 365.23 us/op 0.60
altair processAttestation - setStatus - 1/2 committees join 405.07 us/op 487.60 us/op 0.83
altair processAttestation - setStatus - 2/3 committees join 473.61 us/op 578.17 us/op 0.82
altair processAttestation - setStatus - 4/5 committees join 593.64 us/op 798.39 us/op 0.74
altair processAttestation - setStatus - 100% committees join 796.01 us/op 929.20 us/op 0.86
altair processBlock - 250000 vs - 7PWei normalcase 10.957 ms/op 9.5496 ms/op 1.15
altair processBlock - 250000 vs - 7PWei normalcase hashState 36.510 ms/op 42.166 ms/op 0.87
altair processBlock - 250000 vs - 7PWei worstcase 40.032 ms/op 40.355 ms/op 0.99
altair processBlock - 250000 vs - 7PWei worstcase hashState 97.402 ms/op 90.513 ms/op 1.08
phase0 processBlock - 250000 vs - 7PWei normalcase 3.6090 ms/op 3.0876 ms/op 1.17
phase0 processBlock - 250000 vs - 7PWei worstcase 35.991 ms/op 28.942 ms/op 1.24
altair processEth1Data - 250000 vs - 7PWei normalcase 720.85 us/op 507.11 us/op 1.42
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 15.644 us/op 16.994 us/op 0.92
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 83.226 us/op 89.010 us/op 0.94
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 34.188 us/op 16.807 us/op 2.03
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 18.515 us/op 17.088 us/op 1.08
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 213.22 us/op 228.36 us/op 0.93
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.6485 ms/op 2.2170 ms/op 0.74
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 2.2201 ms/op 2.8845 ms/op 0.77
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 2.0584 ms/op 2.5950 ms/op 0.79
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 4.3591 ms/op 3.3913 ms/op 1.29
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.4722 ms/op 2.6409 ms/op 0.94
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 4.8343 ms/op 4.9563 ms/op 0.98
Tree 40 250000 create 315.65 ms/op 348.78 ms/op 0.91
Tree 40 250000 get(125000) 139.32 ns/op 199.26 ns/op 0.70
Tree 40 250000 set(125000) 849.28 ns/op 1.0286 us/op 0.83
Tree 40 250000 toArray() 24.684 ms/op 19.706 ms/op 1.25
Tree 40 250000 iterate all - toArray() + loop 21.100 ms/op 19.303 ms/op 1.09
Tree 40 250000 iterate all - get(i) 53.403 ms/op 67.140 ms/op 0.80
MutableVector 250000 create 12.506 ms/op 19.815 ms/op 0.63
MutableVector 250000 get(125000) 6.6270 ns/op 6.8600 ns/op 0.97
MutableVector 250000 set(125000) 216.13 ns/op 267.95 ns/op 0.81
MutableVector 250000 toArray() 3.3664 ms/op 3.8274 ms/op 0.88
MutableVector 250000 iterate all - toArray() + loop 4.0754 ms/op 3.6683 ms/op 1.11
MutableVector 250000 iterate all - get(i) 1.3858 ms/op 1.5558 ms/op 0.89
Array 250000 create 3.6932 ms/op 3.6100 ms/op 1.02
Array 250000 clone - spread 1.2786 ms/op 1.2468 ms/op 1.03
Array 250000 get(125000) 1.3450 ns/op 1.0180 ns/op 1.32
Array 250000 set(125000) 1.7160 ns/op 4.0890 ns/op 0.42
Array 250000 iterate all - loop 160.33 us/op 164.28 us/op 0.98
effectiveBalanceIncrements clone Uint8Array 300000 35.835 us/op 32.280 us/op 1.11
effectiveBalanceIncrements clone MutableVector 300000 466.00 ns/op 371.00 ns/op 1.26
effectiveBalanceIncrements rw all Uint8Array 300000 206.18 us/op 200.03 us/op 1.03
effectiveBalanceIncrements rw all MutableVector 300000 144.23 ms/op 83.512 ms/op 1.73
phase0 afterProcessEpoch - 250000 vs - 7PWei 82.058 ms/op 114.29 ms/op 0.72
phase0 beforeProcessEpoch - 250000 vs - 7PWei 53.680 ms/op 57.871 ms/op 0.93
altair processEpoch - mainnet_e81889 479.90 ms/op 555.73 ms/op 0.86
mainnet_e81889 - altair beforeProcessEpoch 78.504 ms/op 85.171 ms/op 0.92
mainnet_e81889 - altair processJustificationAndFinalization 14.242 us/op 22.647 us/op 0.63
mainnet_e81889 - altair processInactivityUpdates 6.5596 ms/op 6.7009 ms/op 0.98
mainnet_e81889 - altair processRewardsAndPenalties 66.065 ms/op 67.444 ms/op 0.98
mainnet_e81889 - altair processRegistryUpdates 2.2160 us/op 2.8820 us/op 0.77
mainnet_e81889 - altair processSlashings 696.00 ns/op 1.1690 us/op 0.60
mainnet_e81889 - altair processEth1DataReset 926.00 ns/op 800.00 ns/op 1.16
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.0379 ms/op 2.5820 ms/op 0.40
mainnet_e81889 - altair processSlashingsReset 4.5930 us/op 4.5790 us/op 1.00
mainnet_e81889 - altair processRandaoMixesReset 6.8110 us/op 11.021 us/op 0.62
mainnet_e81889 - altair processHistoricalRootsUpdate 1.2900 us/op 1.7340 us/op 0.74
mainnet_e81889 - altair processParticipationFlagUpdates 2.5750 us/op 4.8950 us/op 0.53
mainnet_e81889 - altair processSyncCommitteeUpdates 1.1360 us/op 1.0440 us/op 1.09
mainnet_e81889 - altair afterProcessEpoch 88.183 ms/op 128.56 ms/op 0.69
capella processEpoch - mainnet_e217614 1.9620 s/op 2.4388 s/op 0.80
mainnet_e217614 - capella beforeProcessEpoch 443.47 ms/op 542.88 ms/op 0.82
mainnet_e217614 - capella processJustificationAndFinalization 15.752 us/op 22.229 us/op 0.71
mainnet_e217614 - capella processInactivityUpdates 22.049 ms/op 22.562 ms/op 0.98
mainnet_e217614 - capella processRewardsAndPenalties 622.86 ms/op 576.57 ms/op 1.08
mainnet_e217614 - capella processRegistryUpdates 27.632 us/op 27.621 us/op 1.00
mainnet_e217614 - capella processSlashings 892.00 ns/op 1.6730 us/op 0.53
mainnet_e217614 - capella processEth1DataReset 844.00 ns/op 999.00 ns/op 0.84
mainnet_e217614 - capella processEffectiveBalanceUpdates 3.7801 ms/op 15.868 ms/op 0.24
mainnet_e217614 - capella processSlashingsReset 4.6760 us/op 9.4940 us/op 0.49
mainnet_e217614 - capella processRandaoMixesReset 7.7760 us/op 8.7470 us/op 0.89
mainnet_e217614 - capella processHistoricalRootsUpdate 1.0500 us/op 1.0450 us/op 1.00
mainnet_e217614 - capella processParticipationFlagUpdates 2.7230 us/op 2.3100 us/op 1.18
mainnet_e217614 - capella afterProcessEpoch 230.70 ms/op 321.68 ms/op 0.72
phase0 processEpoch - mainnet_e58758 497.47 ms/op 600.57 ms/op 0.83
mainnet_e58758 - phase0 beforeProcessEpoch 150.44 ms/op 201.03 ms/op 0.75
mainnet_e58758 - phase0 processJustificationAndFinalization 20.699 us/op 32.684 us/op 0.63
mainnet_e58758 - phase0 processRewardsAndPenalties 69.486 ms/op 76.297 ms/op 0.91
mainnet_e58758 - phase0 processRegistryUpdates 14.773 us/op 23.223 us/op 0.64
mainnet_e58758 - phase0 processSlashings 995.00 ns/op 1.2340 us/op 0.81
mainnet_e58758 - phase0 processEth1DataReset 889.00 ns/op 810.00 ns/op 1.10
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.4430 ms/op 1.4066 ms/op 1.03
mainnet_e58758 - phase0 processSlashingsReset 4.0380 us/op 5.4190 us/op 0.75
mainnet_e58758 - phase0 processRandaoMixesReset 7.1710 us/op 11.820 us/op 0.61
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.0190 us/op 1.0580 us/op 0.96
mainnet_e58758 - phase0 processParticipationRecordUpdates 6.5300 us/op 5.8580 us/op 1.11
mainnet_e58758 - phase0 afterProcessEpoch 72.521 ms/op 104.20 ms/op 0.70
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.0397 ms/op 1.3458 ms/op 0.77
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.1037 ms/op 1.9136 ms/op 0.58
altair processInactivityUpdates - 250000 normalcase 29.714 ms/op 32.828 ms/op 0.91
altair processInactivityUpdates - 250000 worstcase 30.256 ms/op 35.378 ms/op 0.86
phase0 processRegistryUpdates - 250000 normalcase 12.579 us/op 21.384 us/op 0.59
phase0 processRegistryUpdates - 250000 badcase_full_deposits 477.41 us/op 616.17 us/op 0.77
phase0 processRegistryUpdates - 250000 worstcase 0.5 135.30 ms/op 149.12 ms/op 0.91
altair processRewardsAndPenalties - 250000 normalcase 63.147 ms/op 83.060 ms/op 0.76
altair processRewardsAndPenalties - 250000 worstcase 73.714 ms/op 75.550 ms/op 0.98
phase0 getAttestationDeltas - 250000 normalcase 6.4735 ms/op 9.3085 ms/op 0.70
phase0 getAttestationDeltas - 250000 worstcase 5.8060 ms/op 9.1241 ms/op 0.64
phase0 processSlashings - 250000 worstcase 88.468 us/op 126.92 us/op 0.70
altair processSyncCommitteeUpdates - 250000 104.34 ms/op 163.02 ms/op 0.64
BeaconState.hashTreeRoot - No change 368.00 ns/op 366.00 ns/op 1.01
BeaconState.hashTreeRoot - 1 full validator 87.466 us/op 112.28 us/op 0.78
BeaconState.hashTreeRoot - 32 full validator 871.71 us/op 1.1744 ms/op 0.74
BeaconState.hashTreeRoot - 512 full validator 12.615 ms/op 12.361 ms/op 1.02
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 128.45 us/op 170.93 us/op 0.75
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.9215 ms/op 2.4537 ms/op 0.78
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 30.208 ms/op 34.687 ms/op 0.87
BeaconState.hashTreeRoot - 1 balances 154.82 us/op 149.88 us/op 1.03
BeaconState.hashTreeRoot - 32 balances 893.43 us/op 1.2868 ms/op 0.69
BeaconState.hashTreeRoot - 512 balances 8.1012 ms/op 13.755 ms/op 0.59
BeaconState.hashTreeRoot - 250000 balances 160.37 ms/op 238.16 ms/op 0.67
aggregationBits - 2048 els - zipIndexesInBitList 22.357 us/op 26.162 us/op 0.85
byteArrayEquals 32 62.703 ns/op 75.017 ns/op 0.84
Buffer.compare 32 36.772 ns/op 55.357 ns/op 0.66
byteArrayEquals 1024 1.6667 us/op 2.0487 us/op 0.81
Buffer.compare 1024 43.022 ns/op 72.156 ns/op 0.60
byteArrayEquals 16384 26.392 us/op 32.599 us/op 0.81
Buffer.compare 16384 192.93 ns/op 267.11 ns/op 0.72
byteArrayEquals 123687377 219.51 ms/op 246.28 ms/op 0.89
Buffer.compare 123687377 5.2749 ms/op 7.2781 ms/op 0.72
byteArrayEquals 32 - diff last byte 64.728 ns/op 70.955 ns/op 0.91
Buffer.compare 32 - diff last byte 43.479 ns/op 57.152 ns/op 0.76
byteArrayEquals 1024 - diff last byte 1.8597 us/op 2.0654 us/op 0.90
Buffer.compare 1024 - diff last byte 53.154 ns/op 72.709 ns/op 0.73
byteArrayEquals 16384 - diff last byte 31.527 us/op 32.372 us/op 0.97
Buffer.compare 16384 - diff last byte 206.33 ns/op 252.17 ns/op 0.82
byteArrayEquals 123687377 - diff last byte 240.81 ms/op 251.15 ms/op 0.96
Buffer.compare 123687377 - diff last byte 5.6037 ms/op 7.9564 ms/op 0.70
byteArrayEquals 32 - random bytes 4.8340 ns/op 6.4110 ns/op 0.75
Buffer.compare 32 - random bytes 43.359 ns/op 64.331 ns/op 0.67
byteArrayEquals 1024 - random bytes 5.0370 ns/op 6.0040 ns/op 0.84
Buffer.compare 1024 - random bytes 48.033 ns/op 63.052 ns/op 0.76
byteArrayEquals 16384 - random bytes 5.0710 ns/op 5.5680 ns/op 0.91
Buffer.compare 16384 - random bytes 43.204 ns/op 62.102 ns/op 0.70
byteArrayEquals 123687377 - random bytes 8.8400 ns/op 8.6900 ns/op 1.02
Buffer.compare 123687377 - random bytes 54.250 ns/op 69.950 ns/op 0.78
regular array get 100000 times 44.754 us/op 46.274 us/op 0.97
wrappedArray get 100000 times 41.618 us/op 46.778 us/op 0.89
arrayWithProxy get 100000 times 9.4315 ms/op 16.620 ms/op 0.57
ssz.Root.equals 55.736 ns/op 57.110 ns/op 0.98
byteArrayEquals 54.807 ns/op 62.530 ns/op 0.88
Buffer.compare 10.657 ns/op 12.139 ns/op 0.88
shuffle list - 16384 els 5.8997 ms/op 9.0497 ms/op 0.65
shuffle list - 250000 els 89.277 ms/op 130.32 ms/op 0.69
processSlot - 1 slots 13.053 us/op 17.666 us/op 0.74
processSlot - 32 slots 2.5504 ms/op 3.3722 ms/op 0.76
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 57.167 ms/op 71.309 ms/op 0.80
getCommitteeAssignments - req 1 vs - 250000 vc 2.4674 ms/op 2.9963 ms/op 0.82
getCommitteeAssignments - req 100 vs - 250000 vc 3.7096 ms/op 4.5955 ms/op 0.81
getCommitteeAssignments - req 1000 vs - 250000 vc 4.0090 ms/op 4.7893 ms/op 0.84
findModifiedValidators - 10000 modified validators 436.66 ms/op 700.56 ms/op 0.62
findModifiedValidators - 1000 modified validators 387.38 ms/op 508.59 ms/op 0.76
findModifiedValidators - 100 modified validators 357.47 ms/op 569.32 ms/op 0.63
findModifiedValidators - 10 modified validators 331.57 ms/op 538.74 ms/op 0.62
findModifiedValidators - 1 modified validators 345.79 ms/op 550.07 ms/op 0.63
findModifiedValidators - no difference 339.32 ms/op 479.45 ms/op 0.71
compare ViewDUs 4.1702 s/op 4.9360 s/op 0.84
compare each validator Uint8Array 1.4510 s/op 1.9576 s/op 0.74
compare ViewDU to Uint8Array 1.0078 s/op 1.5853 s/op 0.64
migrate state 1000000 validators, 24 modified, 0 new 659.63 ms/op 1.1215 s/op 0.59
migrate state 1000000 validators, 1700 modified, 1000 new 914.19 ms/op 1.2643 s/op 0.72
migrate state 1000000 validators, 3400 modified, 2000 new 1.2030 s/op 1.4698 s/op 0.82
migrate state 1500000 validators, 24 modified, 0 new 771.97 ms/op 986.25 ms/op 0.78
migrate state 1500000 validators, 1700 modified, 1000 new 1.0537 s/op 1.3447 s/op 0.78
migrate state 1500000 validators, 3400 modified, 2000 new 1.3296 s/op 1.3805 s/op 0.96
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 6.2100 ns/op 4.5600 ns/op 1.36
state getBlockRootAtSlot - 250000 vs - 7PWei 668.56 ns/op 518.49 ns/op 1.29
computeProposers - vc 250000 8.4400 ms/op 9.9596 ms/op 0.85
computeEpochShuffling - vc 250000 99.091 ms/op 129.93 ms/op 0.76
getNextSyncCommittee - vc 250000 145.08 ms/op 158.82 ms/op 0.91
computeSigningRoot for AttestationData 27.085 us/op 25.754 us/op 1.05
hash AttestationData serialized data then Buffer.toString(base64) 1.3827 us/op 2.3563 us/op 0.59
toHexString serialized data 925.25 ns/op 1.1655 us/op 0.79
Buffer.toString(base64) 192.70 ns/op 224.98 ns/op 0.86

by benchmarkbot/action

@nflaig nflaig marked this pull request as draft March 11, 2024 12:05
@nflaig nflaig added this to the v1.18.0 milestone Mar 12, 2024
jeluard
jeluard previously approved these changes Mar 23, 2024
View reviewed changes
packages/cli/src/cmds/validator/options.ts
@@ -93,12 +94,18 @@ export const keymanagerOptions: CliCommandOptions<KeymanagerArgs> = {
default: false,
group: "keymanager",
},
"keymanager.authEnabled": {
"keymanager.auth": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth documenting in next release, so that people can migrate to the preferred syntax?

@jeluard
Copy link
Contributor

jeluard commented Mar 23, 2024

@nflaig Is there a reason why this PR is in Draft mode?

@nflaig
Copy link
Member Author

nflaig commented Mar 23, 2024

@nflaig Is there a reason why this PR is in Draft mode?

Waiting for spec PR discussion to resolve, might wanna rename flag name

@nflaig nflaig marked this pull request as ready for review March 25, 2024 14:11
@jeluard jeluard self-requested a review March 25, 2024 14:42
@nflaig nflaig merged commit d135329 into unstable Mar 25, 2024
21 of 22 checks passed
@nflaig nflaig deleted the nflaig/configurable-token-path branch March 25, 2024 19:32
@nflaig nflaig mentioned this pull request Mar 28, 2024
Merged
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.18.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeluard jeluard jeluard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nflaig @jeluard @wemeetagain