Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to docusaurus #6533

Merged
merged 8 commits into from
Mar 18, 2024
Merged

Conversation

jeluard
Copy link
Contributor

@jeluard jeluard commented Mar 12, 2024

Motivation

Migrate documentation to docusaurus. Test the deployment here

Relates to #6517

@jeluard jeluard requested a review from a team as a code owner March 12, 2024 16:43
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Merging #6533 (e129356) into unstable (6fe93c1) will decrease coverage by 0.14%.
Report is 10 commits behind head on unstable.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #6533      +/-   ##
============================================
- Coverage     61.53%   61.39%   -0.14%     
============================================
  Files           556      556              
  Lines         58647    58751     +104     
  Branches       1847     1848       +1     
============================================
- Hits          36087    36073      -14     
- Misses        22520    22638     +118     
  Partials         40       40              

.gitignore Outdated Show resolved Hide resolved
@nflaig
Copy link
Member

nflaig commented Mar 14, 2024

I really like the side bar on the right we have for the CLI reference, listing all flags. Would be good if we can keep that
image

@nflaig
Copy link
Member

nflaig commented Mar 14, 2024

We definitely need a detailed visual review of the new docs vs. our current docs, just quickly skimming through

package.json Outdated Show resolved Hide resolved
@@ -198,7 +202,7 @@ function renderSubCommand(sub: SubCommandDefinition, lodestarCommand?: string):
renderOptions(
sub.options,
`### \`${sub.command}\` Options`,
"_Supports all parent command options plus the following:_\n\n<br>"
"_Supports all parent command options plus the following:_\n\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"_Supports all parent command options plus the following:_\n\n"
`_Supports all parent command options plus the following:_${LINE_BREAK}`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that a docusaurus thing? Couldn't find mention of it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. That was a remnant from updating the script to build the cli docs. In some places the line separator needed the extra <br /> but in other it did not to look correct. As long as it no longer a thing we can just use the single LINE_BREAK const.

docs/sidebars.js Outdated Show resolved Hide resolved
Copy link
Member

@matthewkeil matthewkeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice job overall!! Just a few things I noticed but great work!

Just as a note I did not visually check all the pages, I only reviewed the github diff and started things up to make sure all worked on my box as well (WOMM works on my machine lol). There was a lot here so we may need another bite at the apple.

But again, great addition to the codebase!! 🚀

@matthewkeil
Copy link
Member

I really like the side bar on the right we have for the CLI reference, listing all flags. Would be good if we can keep that !

I also very much agree with this!!! I saw some options for generating a minimap so should be possible

@philknows
Copy link
Member

I really like the side bar on the right we have for the CLI reference, listing all flags. Would be good if we can keep that image

Definitely useful. Would love if there was a way to get the list of commands on the right sidebar, that seems to be able to show the heading titles?

@philknows
Copy link
Member

  • do we wanna look into adding versioning, or at least show the lasted version here?

I think this would be a good idea if we can implement this.

@philknows
Copy link
Member

I think overall this is a good start, with this PR focusing on the migration itself, we should aim to get this setup with the top level settings we want and the high level structure of our docs. We can then do follow up PRs also which can go further into the contents of the docs such as rearranging and cleaning up context.

docs/src/css/custom.css Outdated Show resolved Hide resolved
docs/src/css/custom.css Outdated Show resolved Hide resolved
jeluard and others added 4 commits March 15, 2024 03:00
Co-authored-by: Matthew Keil <me@matthewkeil.com>
Co-authored-by: Matthew Keil <me@matthewkeil.com>
Co-authored-by: Phil Ngo <58080811+philknows@users.noreply.github.com>
Co-authored-by: Phil Ngo <58080811+philknows@users.noreply.github.com>
@jeluard
Copy link
Contributor Author

jeluard commented Mar 15, 2024

@nflaig

The footer is the regular docusaurus one, it looks a bit off because it doesn't contain much for now. We could revisit this once we adapt the doc layout.

Regarding versioning, I plan to address that in a follow up PR.

Copy link
Member

@matthewkeil matthewkeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Talked with @jeluard in DM and a couple of the clean-up things will be handled in separate PR. You rock dude!! Good job! 🎸

@jeluard jeluard merged commit 4686ad1 into ChainSafe:unstable Mar 18, 2024
17 of 20 checks passed
@jeluard jeluard deleted the jeluard/docusaurus-migration branch March 18, 2024 10:43
@jeluard jeluard changed the title feat: docusaurus migration Migrate to docusaurus Mar 21, 2024
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.18.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants