fix: light-client start should never block #6619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeluard
force-pushed
the
jeluard/fix-lc-start
branch
from
e00df19
to
62db411
Compare
jeluard
changed the title
jeluard
changed the title
jeluard
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6619 +/- ##
============================================
- Coverage 61.61% 61.60% -0.01%
============================================
Files 556 556
Lines 58566 58569 +3
Branches 1859 1859
============================================
Hits 36084 36084
- Misses 22441 22444 +3
Partials 41 41 |
Performance Report✔️ no performance regression detected Full benchmark results
|
nazarhussain
requested changes
Apr 2, 2024
packages/light-client/src/index.ts
Outdated
| void this.runLoop(); | ||
|
|
||
| return startPromise; | ||
| return this.runLoop(); |
There was a problem hiding this comment.
The problem I see in this approach is that normally user will use await client.start(), that will block the event loop forever.
The syntax void this.runLoop() is a way to put the run loop in the background so the await client.start() does not block.
There was a problem hiding this comment.
Makes sense, so I guess the previous approach made more sense.
There was a problem hiding this comment.
Can't we just check if light client is already started and return right away when start() is called? The second start call should be a no-op
jeluard
force-pushed
the
jeluard/fix-lc-start
branch
from
62db411
to
cf47a84
Compare
nazarhussain
approved these changes
Apr 3, 2024
|
🎉 This PR is included in v1.18.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
light-clientstart should never block.Description
Currently, calling
light-clientstart twice in a row will wait forever.Simplify the wait logic by leveraging the fact that
runLoopalready awaits forstartedstate.