-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: export beacon utils to be reused by other packages #6640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6640 +/- ##
=========================================
Coverage 61.69% 61.69%
=========================================
Files 556 556
Lines 58820 58820
Branches 1887 1887
=========================================
Hits 36287 36287
Misses 22492 22492
Partials 41 41 |
Performance Report✔️ no performance regression detected Full benchmark results
|
matthewkeil
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! 🚀
nflaig
reviewed
Apr 5, 2024
nflaig
approved these changes
Apr 5, 2024
🎉 This PR is included in v1.18.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make the packages and complex code more re-useable.
Description
We need to use
kzg
implementation and trusted setup during the blobs testing on the CLI package and sim tests.It would be difficult to maintain if we duplicate logic like
kzg
in different packages, so we have to export such utils.Limit the utils export only to important ones, which are integral for application behavior.
Steps to test or reproduce