-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add basic devcontainer support #6667
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6667 +/- ##
=========================================
Coverage 61.81% 61.81%
=========================================
Files 556 556
Lines 59050 59050
Branches 1898 1898
=========================================
Hits 36502 36502
Misses 22505 22505
Partials 43 43 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Have you tried using this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested devcontainers myself but is this VS code specific and requires an extension? Might be worth to document how to use this in contribution docs
@wemeetagain yes it does work fine, you can test it in codespaces directly from my fork. Great for PR review! @nflaig good point, need some docs |
🎉 This PR is included in v1.18.0 🎉 |
Motivation
Ease setup for environment supporting devcontainer.
e.g. allows MacOS users to easily develop with vscode under linux via docker or remote via ssh. Also improves the Codespaces experience.