Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic devcontainer support #6667

Merged
merged 5 commits into from
Apr 18, 2024
Merged

feat: add basic devcontainer support #6667

merged 5 commits into from
Apr 18, 2024

Conversation

jeluard
Copy link
Contributor

@jeluard jeluard commented Apr 12, 2024

Motivation

Ease setup for environment supporting devcontainer.
e.g. allows MacOS users to easily develop with vscode under linux via docker or remote via ssh. Also improves the Codespaces experience.

@jeluard jeluard requested a review from a team as a code owner April 12, 2024 19:14
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Merging #6667 (efed3e1) into unstable (ae984f0) will not change coverage.
Report is 6 commits behind head on unstable.
The diff coverage is n/a.

❗ Current head efed3e1 differs from pull request most recent head 63de26e. Consider uploading reports for the commit 63de26e to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #6667   +/-   ##
=========================================
  Coverage     61.81%   61.81%           
=========================================
  Files           556      556           
  Lines         59050    59050           
  Branches       1898     1898           
=========================================
  Hits          36502    36502           
  Misses        22505    22505           
  Partials         43       43           

wemeetagain
wemeetagain previously approved these changes Apr 17, 2024
Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Have you tried using this?

Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested devcontainers myself but is this VS code specific and requires an extension? Might be worth to document how to use this in contribution docs

@jeluard
Copy link
Contributor Author

jeluard commented Apr 17, 2024

@wemeetagain yes it does work fine, you can test it in codespaces directly from my fork. Great for PR review!
Capture d’écran 2024-04-17 à 22 52 14

Capture d’écran 2024-04-17 à 23 11 22

@nflaig good point, need some docs

CONTRIBUTING.md Outdated Show resolved Hide resolved
@jeluard jeluard merged commit 252fd2f into ChainSafe:unstable Apr 18, 2024
20 checks passed
@jeluard jeluard deleted the jeluard/devcontainer branch April 18, 2024 13:46
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.18.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants