-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added release page in docs #6669
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6669 +/- ##
============================================
+ Coverage 61.67% 61.81% +0.13%
============================================
Files 556 556
Lines 58834 59050 +216
Branches 1888 1898 +10
============================================
+ Hits 36288 36502 +214
Misses 22505 22505
- Partials 41 43 +2 |
Since we're starting with just linux x86_64 and arm64 binaries, I think its fine to just group them together like you have now. |
@wemeetagain Right, I'm using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would make more sense to add an entry to installation page. We don't really need to list older versions (rather version docs) and binaries is just one way to install Lodestar, having a Releases page like this even before Introduction gives a wrong impression.
I tend to agree with @nflaig here. Binaries are just another installation method and should just have its own section under Installation. I do like the way you cleanly table the releases here, but we definitely don't need to list all of them. I would maybe only go 5 releases back at most, similar to what we would be doing with docs versions. There should be no reason why (nor should we promote) having people stay more than 5 releases behind. This is a pretty weak assumption on my part and open to other opinions. |
What about having a separate page per installation method? We had this previously (before #6134), this makes it easier to read and less overloaded with instructions that are unrelated to each other. |
That is also an option so we can keep various installation methods and their quirks separate from each other. So perhaps:
|
or subsections in installation
Maybe we need to rethink what should be part of getting started, just having installation in there is also a bit strange |
It probably makes sense to reconsider this in the context of #6550 |
is this a possible layout we can go for right now? This feels important to have on the next release, otherwise we will have really low visibilty on the binaries as an installation option (other than announcing it in release notes) |
I would say as a stop-gap measure, we can at least get the layout for |
Would make sense to bundle this page with the new docs layout, one less broken link to deal with. |
It's been decided to rely on GitHub releases page for now instead. |
Are we still gonna highlight binaries as an installation method in the docs? We can just ref to release on github for users to find the download link |
Yeah I'm fine with how it is now, but I understand you wanted it as a higher level heading on its own page based on the LH docs structure. I'm indifferent. As long as it's in the docs, that's what is most important for now IMO. |
Motivation
Display releases in the documentation
This is a first draft aiming at initiating discussion to figure out what is the best option to share releases.
I can see 2 angles: