-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generalize blobs to data for extension ready for ils and/or data columns #6693
Conversation
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
a note for reviewers, this PR also adds a new field "dataAvailabilityStatus" to forkchoice |
packages/beacon-node/src/chain/seenCache/seenGossipBlockInput.ts
Outdated
Show resolved
Hide resolved
…a columns rename types and fix references to them update forkchoice and availability flow propagate changes to the codebase lint and tsc some fixes cleanup test run fixes fix the tests fix apply feedback
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #6693 +/- ##
============================================
- Coverage 62.75% 62.75% -0.01%
============================================
Files 578 578
Lines 61280 61347 +67
Branches 2116 2116
============================================
+ Hits 38459 38498 +39
- Misses 22783 22811 +28
Partials 38 38 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
🎉 This PR is included in v1.20.0 🎉 |
to avoid redoing the same work on different branches and have a clean way to extend data requirements