Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix balance spec tests #6777

Merged
merged 3 commits into from
May 14, 2024
Merged

Conversation

matthewkeil
Copy link
Member

Motivation

Fixes several invalid state root errors in the spec tests. Only three invalid conditions remain.

Description

  • removes check of cache.balances
  • removes additional condition from effective balance check (not in spec)
  • prevents negative balances

@matthewkeil matthewkeil requested a review from a team as a code owner May 14, 2024 15:22
@matthewkeil matthewkeil changed the title Mkeil/fix balance spec tests test: fix balance spec tests May 14, 2024
@twoeths twoeths merged commit ca462a2 into electra-fork May 14, 2024
6 of 7 checks passed
@twoeths twoeths deleted the mkeil/fix-balance-spec-tests branch May 14, 2024 15:42
g11tech pushed a commit that referenced this pull request May 24, 2024
* fix: remove epochCache.balances and invalid MAX_EFFECTIVE_BALANCE check

* fix: update rewardsAndPenalties balance updates

* docs: add comment to check epochTransitionCache
g11tech pushed a commit to g11tech/lodestar that referenced this pull request Jun 19, 2024
* fix: remove epochCache.balances and invalid MAX_EFFECTIVE_BALANCE check

* fix: update rewardsAndPenalties balance updates

* docs: add comment to check epochTransitionCache
g11tech pushed a commit that referenced this pull request Jun 25, 2024
* fix: remove epochCache.balances and invalid MAX_EFFECTIVE_BALANCE check

* fix: update rewardsAndPenalties balance updates

* docs: add comment to check epochTransitionCache
g11tech pushed a commit that referenced this pull request Jun 25, 2024
* fix: remove epochCache.balances and invalid MAX_EFFECTIVE_BALANCE check

* fix: update rewardsAndPenalties balance updates

* docs: add comment to check epochTransitionCache
g11tech pushed a commit that referenced this pull request Jul 1, 2024
* fix: remove epochCache.balances and invalid MAX_EFFECTIVE_BALANCE check

* fix: update rewardsAndPenalties balance updates

* docs: add comment to check epochTransitionCache
g11tech pushed a commit that referenced this pull request Jul 30, 2024
* fix: remove epochCache.balances and invalid MAX_EFFECTIVE_BALANCE check

* fix: update rewardsAndPenalties balance updates

* docs: add comment to check epochTransitionCache
g11tech pushed a commit that referenced this pull request Jul 31, 2024
* fix: remove epochCache.balances and invalid MAX_EFFECTIVE_BALANCE check

* fix: update rewardsAndPenalties balance updates

* docs: add comment to check epochTransitionCache
g11tech pushed a commit that referenced this pull request Aug 2, 2024
* fix: remove epochCache.balances and invalid MAX_EFFECTIVE_BALANCE check

* fix: update rewardsAndPenalties balance updates

* docs: add comment to check epochTransitionCache
g11tech pushed a commit that referenced this pull request Aug 9, 2024
* fix: remove epochCache.balances and invalid MAX_EFFECTIVE_BALANCE check

* fix: update rewardsAndPenalties balance updates

* docs: add comment to check epochTransitionCache
g11tech pushed a commit that referenced this pull request Aug 9, 2024
* fix: remove epochCache.balances and invalid MAX_EFFECTIVE_BALANCE check

* fix: update rewardsAndPenalties balance updates

* docs: add comment to check epochTransitionCache
g11tech pushed a commit that referenced this pull request Aug 23, 2024
* fix: remove epochCache.balances and invalid MAX_EFFECTIVE_BALANCE check

* fix: update rewardsAndPenalties balance updates

* docs: add comment to check epochTransitionCache
g11tech pushed a commit that referenced this pull request Aug 27, 2024
* fix: remove epochCache.balances and invalid MAX_EFFECTIVE_BALANCE check

* fix: update rewardsAndPenalties balance updates

* docs: add comment to check epochTransitionCache
philknows pushed a commit that referenced this pull request Sep 3, 2024
* fix: remove epochCache.balances and invalid MAX_EFFECTIVE_BALANCE check

* fix: update rewardsAndPenalties balance updates

* docs: add comment to check epochTransitionCache
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.22.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants