fix: validator monitor summaries should not render during epoch 0 #6791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging but will reopen 6784 until its fixed on unstable |
wemeetagain
approved these changes
May 16, 2024
g11tech
pushed a commit
to g11tech/lodestar
that referenced
this pull request
Jun 19, 2024
…ainSafe#6791) Skip render summary at epoch 0
|
🎉 This PR is included in v1.22.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently at the end of epoch n, we render attestation and block proposal summaries from the epoch n - 1.
At epoch 0, since no epoch -1 summary is available, we should not render any summaries but current behaviour renders summaries from epoch 0.
Note this issue exists in
unstablebranch as well. Merging toelectra-forkfor now as it doesn't show up in nodes connected to mainnet so it's not urgentcloses #6784