Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update withdrawal request container to match consensus spec #6797

Merged
merged 1 commit into from
May 16, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented May 16, 2024

Motivation

Noticed we are no longer following the consensus spec since #6789, the ssz_static tests are failing and there are issues if execution layer withdrawals are submitted to the network.

Description

Update withdrawal request container to match consensus spec

@@ -419,7 +419,7 @@ export function serializeExecutionLayerWithdrawalRequest(
): ExecutionLayerWithdrawalRequestRpc {
return {
sourceAddress: bytesToData(withdrawalRequest.sourceAddress),
validatorPublicKey: bytesToData(withdrawalRequest.validatorPublicKey),
validatorPublicKey: bytesToData(withdrawalRequest.validatorPubkey),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a inconsistency in the execution apis, right now all EL clients besides Besu use validatorPublicKey, this means pairing with Besu will not work right now if execution layer withdrawals requests are submitted to the network.

For now, we should just follow the spec

I opened a PR to potentially address this inconsistency

packages/beacon-node/test/spec/presets/ssz_static.test.ts Outdated Show resolved Hide resolved
@nflaig nflaig force-pushed the nflaig/fix-withdrawal-request branch from a7d26dc to 9d1d263 Compare May 16, 2024 17:22
@nflaig
Copy link
Member Author

nflaig commented May 16, 2024

Confirmed this fixes issues with other clients, only remaining issue is block production with Besu but that needs to be either fixed on their end or the spec.

@nflaig nflaig marked this pull request as ready for review May 16, 2024 18:20
@nflaig nflaig requested a review from a team as a code owner May 16, 2024 18:20
@nflaig nflaig merged commit 4d8ed98 into electra-fork May 16, 2024
13 of 17 checks passed
@nflaig nflaig deleted the nflaig/fix-withdrawal-request branch May 16, 2024 18:23
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.22.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants