fix: incorrect variable access #6862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeluard
commented
Jun 7, 2024
| if (data.length > this.maxSizePerMessage) { | ||
| throw Error(`ssz_snappy encoded data length ${length} > ${this.maxSizePerMessage}`); | ||
| throw Error(`ssz_snappy encoded data length ${data.length} > ${this.maxSizePerMessage}`); |
There was a problem hiding this comment.
window.length was used instead.
There was a problem hiding this comment.
how was the code was compiled?
There was a problem hiding this comment.
I think this is because we include dom lib in our tsconfig.build.json.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #6862 +/- ##
============================================
- Coverage 62.20% 62.20% -0.01%
============================================
Files 571 571
Lines 60021 60022 +1
Branches 1976 1973 -3
============================================
Hits 37334 37334
- Misses 22644 22645 +1
Partials 43 43 |
Performance Report✔️ no performance regression detected Full benchmark results
|
twoeths
approved these changes
Jun 9, 2024
|
🎉 This PR is included in v1.20.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make sure all variable access are correct. Took this opportunity to explicitly implement the
DataTransforminterface.