Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EL triggered consolidation and remove ExecutionLayer prefix #6865

Merged
merged 8 commits into from
Jun 21, 2024

Conversation

ensi321
Copy link
Contributor

@ensi321 ensi321 commented Jun 8, 2024

  • Remove Consolidation and SignedConsolidation ssz type, related signature set and state transition function
  • Remove consolidation from beacon state and add consolidation request to execution payload
  • Add processConsolidationRequest
  • Remove ExecutionLayer prefix from withdrawal request

Spec PR: ethereum/consensus-specs#3775 and ethereum/consensus-specs#3791

@ensi321 ensi321 requested a review from a team as a code owner June 8, 2024 09:00
@ensi321 ensi321 changed the title feat: add EL triggered consolidation feat: add EL triggered consolidation and remove ExecutionLayer prefix Jun 13, 2024
@twoeths
Copy link
Contributor

twoeths commented Jun 14, 2024

@ensi321 spec tests are failing, is that because it does not cover this PR?
need to inspect when spec start failing to trace it later

@ensi321
Copy link
Contributor Author

ensi321 commented Jun 14, 2024

@ensi321 spec tests are failing, is that because it does not cover this PR? need to inspect when spec start failing to trace it later

@twoeths Right. We are working on devnet 1 features, but devnet 1 spec test is not released yet. My plan is to address all the failures when they release it. (Hopefully end of this week)

@ensi321 ensi321 merged commit 85a85a9 into electra-fork Jun 21, 2024
2 of 6 checks passed
@ensi321 ensi321 deleted the nc/el-consolidation branch June 21, 2024 16:33
g11tech pushed a commit that referenced this pull request Jun 25, 2024
…ix (#6865)

* init commit

* Add consolidation request

* fix lint

* Remove ExecutionLayer prefix

* Address comment

* Fix verification logic

* lint

* Add todo
g11tech pushed a commit that referenced this pull request Jun 25, 2024
…ix (#6865)

* init commit

* Add consolidation request

* fix lint

* Remove ExecutionLayer prefix

* Address comment

* Fix verification logic

* lint

* Add todo
g11tech pushed a commit that referenced this pull request Jul 1, 2024
…ix (#6865)

* init commit

* Add consolidation request

* fix lint

* Remove ExecutionLayer prefix

* Address comment

* Fix verification logic

* lint

* Add todo
g11tech pushed a commit that referenced this pull request Jul 30, 2024
…ix (#6865)

* init commit

* Add consolidation request

* fix lint

* Remove ExecutionLayer prefix

* Address comment

* Fix verification logic

* lint

* Add todo
g11tech pushed a commit that referenced this pull request Jul 31, 2024
…ix (#6865)

* init commit

* Add consolidation request

* fix lint

* Remove ExecutionLayer prefix

* Address comment

* Fix verification logic

* lint

* Add todo
g11tech pushed a commit that referenced this pull request Aug 2, 2024
…ix (#6865)

* init commit

* Add consolidation request

* fix lint

* Remove ExecutionLayer prefix

* Address comment

* Fix verification logic

* lint

* Add todo
g11tech pushed a commit that referenced this pull request Aug 9, 2024
…ix (#6865)

* init commit

* Add consolidation request

* fix lint

* Remove ExecutionLayer prefix

* Address comment

* Fix verification logic

* lint

* Add todo
g11tech pushed a commit that referenced this pull request Aug 9, 2024
…ix (#6865)

* init commit

* Add consolidation request

* fix lint

* Remove ExecutionLayer prefix

* Address comment

* Fix verification logic

* lint

* Add todo
g11tech pushed a commit that referenced this pull request Aug 23, 2024
…ix (#6865)

* init commit

* Add consolidation request

* fix lint

* Remove ExecutionLayer prefix

* Address comment

* Fix verification logic

* lint

* Add todo
g11tech pushed a commit that referenced this pull request Aug 27, 2024
…ix (#6865)

* init commit

* Add consolidation request

* fix lint

* Remove ExecutionLayer prefix

* Address comment

* Fix verification logic

* lint

* Add todo
philknows pushed a commit that referenced this pull request Sep 3, 2024
…ix (#6865)

* init commit

* Add consolidation request

* fix lint

* Remove ExecutionLayer prefix

* Address comment

* Fix verification logic

* lint

* Add todo
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.22.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants