-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove no longer supported networks from config #6870
Conversation
@@ -10,7 +10,7 @@ import {NetworkName} from "@lodestar/config/networks.js"; | |||
|
|||
/* eslint-disable no-console */ | |||
|
|||
const networksInInfura: NetworkName[] = ["mainnet", "goerli"]; | |||
const networksInInfura: NetworkName[] = ["mainnet" /*"goerli"*/]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are bunch of Infura related test cases that still reference goerli, needs to be cleaned up separately
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #6870 +/- ##
============================================
- Coverage 62.19% 62.17% -0.03%
============================================
Files 571 569 -2
Lines 60100 60057 -43
Branches 1980 1973 -7
============================================
- Hits 37378 37339 -39
+ Misses 22679 22675 -4
Partials 43 43 |
Performance Report✔️ no performance regression detected Full benchmark results
|
🎉 This PR is included in v1.20.0 🎉 |
Motivation
Cleanup
Description
Remove no longer supported networks from config