-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add workaround to fix fetching state from checkpointz #6874
Conversation
@@ -102,7 +102,7 @@ export function createApiRequest<E extends Endpoint>( | |||
return new Request(url, { | |||
...init, | |||
method: definition.method, | |||
headers: mergeHeaders(headers, req.headers), | |||
headers: mergeHeaders(headers, req.headers, init.headers), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is anyways better imo, we should allow the user to override any header manually via request init
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #6874 +/- ##
============================================
- Coverage 62.75% 62.75% -0.01%
============================================
Files 578 578
Lines 61264 61278 +14
Branches 2114 2112 -2
============================================
+ Hits 38449 38457 +8
- Misses 22776 22783 +7
+ Partials 39 38 -1 |
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
🎉 This PR is included in v1.20.0 🎉 |
Motivation
Adds temporary workaround to fix fetching state from Checkpointz.
Description
mergeHeaders
to support multiple headers as argsEth-consensus-version
header as required by the spec, see Eth-Consensus-Version header is missing in getStateV2 response ethpandaops/checkpointz#164