-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore empty array when filtering validator balances #6878
Conversation
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #6878 +/- ##
=========================================
Coverage 62.76% 62.76%
=========================================
Files 578 578
Lines 61273 61273
Branches 2122 2114 -8
=========================================
Hits 38455 38455
- Misses 22779 22780 +1
+ Partials 39 38 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Is there anymore endpoint that requires similar treatment?
Any POST endpoint that takes an array as filter, we might wanna apply the same to rewards endpoints
|
Also noticed validation is too strict for rewards routes (see #6881), I think we should also update those and ignore empty |
🎉 This PR is included in v1.20.0 🎉 |
Motivation
Similar to #6876, and further clarified in ethereum/beacon-APIs#453
Description
Ignore empty array when filtering validator balances