Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: review #6825 #6887

Merged
merged 1 commit into from
Jun 16, 2024
Merged

chore: review #6825 #6887

merged 1 commit into from
Jun 16, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Jun 15, 2024

  • narrow down some type casts
  • remove unrelated formatting changes
  • fix a few wrong types

@nflaig nflaig requested a review from a team as a code owner June 15, 2024 16:38
@nflaig nflaig mentioned this pull request Jun 15, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.65%. Comparing base (f33b835) to head (d7a210d).

Additional details and impacted files 
@@                Coverage Diff                 @@
##           nh/types-refactor    #6887   +/-   ##
==================================================
  Coverage              62.65%   62.65%           
==================================================
  Files                    575      575           
  Lines                  61203    61201    -2     
  Branches                2117     2119    +2     
==================================================
- Hits                   38348    38347    -1     
+ Misses                 22816    22815    -1     
  Partials                  39       39

@wemeetagain wemeetagain merged commit 04c38a1 into nh/types-refactor Jun 16, 2024
17 checks passed
@wemeetagain wemeetagain deleted the nflaig/review-6825 branch June 16, 2024 15:40
nazarhussain added a commit that referenced this pull request Jun 24, 2024
@nazarhussain @nflaig
refactor: improve types package to use forks as generics (#6825)
802a875 
* Update the types to use generics

* Update the types with default generics

* Fix the block type

* Add missing type

* Add missing type

* Add ssz types

* Remove allForks namespace

* Make ssz types generic

* Update config package

* Fix blok fork types

* Fix api package types

* Update types

* Update state-transition package

* Update config package

* Fix types

* Fix types for all packages

* Update api package

* Fix types for tests files

* Fix ssz types

* Fix build error

* Fix lint errors

* Fix lint errors

* Fix type issues after rebase

* Update redundant generics

* Fix the type

* Update types to use single generic

* Fix all types

* Fix the code as per feedback

* Update the code with feedback

* Update packages/types/README.md

Co-authored-by: Nico Flaig <nflaig@protonmail.com>

* chore: review #6825 (#6887)

Review #6825

* Fix publishBlockWrapper input type

* Updated the type guard

* Remove ssz instance type

* Rename BlindedExecutionPayload to ExecutionPayloadheader

* Update code as per feedback

---------

Co-authored-by: Nico Flaig <nflaig@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nflaig @wemeetagain