Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove all* types objects #6904

Merged
merged 16 commits into from
Jun 27, 2024
Merged

chore: remove all* types objects #6904

merged 16 commits into from
Jun 27, 2024

Conversation

nazarhussain
Copy link
Contributor

Motivation

Improve consistent usage of types.

Description

  • Remove all objects with pattern allExecution, allLightclient..
  • Replace with a consistent usage with sszTypesFor helper.

Steps to test or reproduce

  • Run all tests

@nazarhussain nazarhussain requested a review from a team as a code owner June 24, 2024 10:52
@nazarhussain nazarhussain self-assigned this Jun 24, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.70968% with 7 lines in your changes missing coverage. Please review.

Project coverage is 62.52%. Comparing base (fe23f68) to head (40451cd).
Report is 1 commits behind head on unstable.

❗ Current head 40451cd differs from pull request most recent head 2e1d27a

Please upload reports for the commit 2e1d27a to get more accurate results.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #6904      +/-   ##
============================================
- Coverage     62.55%   62.52%   -0.03%     
============================================
  Files           575      575              
  Lines         61045    60994      -51     
  Branches       2123     2128       +5     
============================================
- Hits          38187    38139      -48     
+ Misses        22819    22816       -3     
  Partials         39       39

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 24, 2024 •
edited
Loading

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 655903b Previous: 8cb08ff Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 870.39 us/op 512.16 us/op 1.70
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 70.604 us/op 52.922 us/op 1.33
BLS verify - blst-native 1.3776 ms/op 1.2685 ms/op 1.09
BLS verifyMultipleSignatures 3 - blst-native 2.9177 ms/op 2.7120 ms/op 1.08
BLS verifyMultipleSignatures 8 - blst-native 6.3823 ms/op 6.2377 ms/op 1.02
BLS verifyMultipleSignatures 32 - blst-native 24.450 ms/op 21.928 ms/op 1.11
BLS verifyMultipleSignatures 64 - blst-native 48.015 ms/op 43.220 ms/op 1.11
BLS verifyMultipleSignatures 128 - blst-native 99.618 ms/op 85.380 ms/op 1.17
BLS deserializing 10000 signatures 1.0021 s/op 880.27 ms/op 1.14
BLS deserializing 100000 signatures 9.6090 s/op 9.1411 s/op 1.05
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.4150 ms/op 1.4734 ms/op 0.96
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.5869 ms/op 1.4626 ms/op 1.08
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.6061 ms/op 2.2858 ms/op 1.14
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.9450 ms/op 3.3979 ms/op 1.16
BLS verifyMultipleSignatures - same message - 128 - blst-native 6.3998 ms/op 5.6372 ms/op 1.14
BLS aggregatePubkeys 32 - blst-native 29.301 us/op 27.246 us/op 1.08
BLS aggregatePubkeys 128 - blst-native 109.58 us/op 104.98 us/op 1.04
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 76.231 ms/op 117.82 ms/op 0.65
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 61.632 ms/op 88.175 ms/op 0.70
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 40.566 ms/op 48.857 ms/op 0.83
getSlashingsAndExits - default max 120.86 us/op 229.04 us/op 0.53
getSlashingsAndExits - 2k 363.96 us/op 329.09 us/op 1.11
proposeBlockBody type=full, size=empty 6.6441 ms/op 5.9373 ms/op 1.12
isKnown best case - 1 super set check 557.00 ns/op 358.00 ns/op 1.56
isKnown normal case - 2 super set checks 562.00 ns/op 364.00 ns/op 1.54
isKnown worse case - 16 super set checks 568.00 ns/op 431.00 ns/op 1.32
InMemoryCheckpointStateCache - add get delete 6.8320 us/op 6.2000 us/op 1.10
validate api signedAggregateAndProof - struct 2.9595 ms/op 2.7497 ms/op 1.08
validate gossip signedAggregateAndProof - struct 2.9681 ms/op 2.7804 ms/op 1.07
validate gossip attestation - vc 640000 1.3939 ms/op 1.3453 ms/op 1.04
batch validate gossip attestation - vc 640000 - chunk 32 166.55 us/op 168.19 us/op 0.99
batch validate gossip attestation - vc 640000 - chunk 64 147.06 us/op 142.56 us/op 1.03
batch validate gossip attestation - vc 640000 - chunk 128 136.81 us/op 129.18 us/op 1.06
batch validate gossip attestation - vc 640000 - chunk 256 133.77 us/op 130.02 us/op 1.03
pickEth1Vote - no votes 1.2723 ms/op 1.1812 ms/op 1.08
pickEth1Vote - max votes 9.9180 ms/op 9.4035 ms/op 1.05
pickEth1Vote - Eth1Data hashTreeRoot value x2048 15.615 ms/op 14.288 ms/op 1.09
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 21.544 ms/op 19.294 ms/op 1.12
pickEth1Vote - Eth1Data fastSerialize value x2048 638.68 us/op 506.48 us/op 1.26
pickEth1Vote - Eth1Data fastSerialize tree x2048 4.9934 ms/op 3.9629 ms/op 1.26
bytes32 toHexString 652.00 ns/op 482.00 ns/op 1.35
bytes32 Buffer.toString(hex) 268.00 ns/op 256.00 ns/op 1.05
bytes32 Buffer.toString(hex) from Uint8Array 456.00 ns/op 429.00 ns/op 1.06
bytes32 Buffer.toString(hex) + 0x 279.00 ns/op 259.00 ns/op 1.08
Object access 1 prop 0.18600 ns/op 0.15000 ns/op 1.24
Map access 1 prop 0.15000 ns/op 0.14800 ns/op 1.01
Object get x1000 6.8030 ns/op 6.2920 ns/op 1.08
Map get x1000 7.0530 ns/op 6.6470 ns/op 1.06
Object set x1000 45.604 ns/op 40.221 ns/op 1.13
Map set x1000 31.313 ns/op 24.523 ns/op 1.28
Return object 10000 times 0.32480 ns/op 0.31090 ns/op 1.04
Throw Error 10000 times 3.6661 us/op 3.5789 us/op 1.02
fastMsgIdFn sha256 / 200 bytes 2.4600 us/op 2.4260 us/op 1.01
fastMsgIdFn h32 xxhash / 200 bytes 296.00 ns/op 300.00 ns/op 0.99
fastMsgIdFn h64 xxhash / 200 bytes 309.00 ns/op 280.00 ns/op 1.10
fastMsgIdFn sha256 / 1000 bytes 8.1750 us/op 7.7530 us/op 1.05
fastMsgIdFn h32 xxhash / 1000 bytes 465.00 ns/op 430.00 ns/op 1.08
fastMsgIdFn h64 xxhash / 1000 bytes 390.00 ns/op 355.00 ns/op 1.10
fastMsgIdFn sha256 / 10000 bytes 70.983 us/op 67.572 us/op 1.05
fastMsgIdFn h32 xxhash / 10000 bytes 2.1500 us/op 1.9540 us/op 1.10
fastMsgIdFn h64 xxhash / 10000 bytes 1.4670 us/op 1.2440 us/op 1.18
send data - 1000 256B messages 15.743 ms/op 14.346 ms/op 1.10
send data - 1000 512B messages 21.727 ms/op 19.241 ms/op 1.13
send data - 1000 1024B messages 32.045 ms/op 27.767 ms/op 1.15
send data - 1000 1200B messages 33.253 ms/op 29.112 ms/op 1.14
send data - 1000 2048B messages 38.367 ms/op 35.354 ms/op 1.09
send data - 1000 4096B messages 35.146 ms/op 34.994 ms/op 1.00
send data - 1000 16384B messages 80.354 ms/op 77.988 ms/op 1.03
send data - 1000 65536B messages 243.25 ms/op 214.44 ms/op 1.13
enrSubnets - fastDeserialize 64 bits 1.4390 us/op 1.2640 us/op 1.14
enrSubnets - ssz BitVector 64 bits 489.00 ns/op 419.00 ns/op 1.17
enrSubnets - fastDeserialize 4 bits 203.00 ns/op 194.00 ns/op 1.05
enrSubnets - ssz BitVector 4 bits 450.00 ns/op 417.00 ns/op 1.08
prioritizePeers score -10:0 att 32-0.1 sync 2-0 181.85 us/op 159.58 us/op 1.14
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 229.91 us/op 189.04 us/op 1.22
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 324.66 us/op 279.24 us/op 1.16
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 531.08 us/op 452.19 us/op 1.17
prioritizePeers score 0:0 att 64-1 sync 4-1 710.36 us/op 653.60 us/op 1.09
array of 16000 items push then shift 1.7992 us/op 1.6961 us/op 1.06
LinkedList of 16000 items push then shift 8.6650 ns/op 7.4700 ns/op 1.16
array of 16000 items push then pop 139.41 ns/op 125.73 ns/op 1.11
LinkedList of 16000 items push then pop 8.4600 ns/op 7.4480 ns/op 1.14
array of 24000 items push then shift 2.6444 us/op 2.5110 us/op 1.05
LinkedList of 24000 items push then shift 8.5250 ns/op 7.5860 ns/op 1.12
array of 24000 items push then pop 178.88 ns/op 168.94 ns/op 1.06
LinkedList of 24000 items push then pop 8.4290 ns/op 8.5620 ns/op 0.98
intersect bitArray bitLen 8 6.9390 ns/op 7.1940 ns/op 0.96
intersect array and set length 8 56.785 ns/op 50.250 ns/op 1.13
intersect bitArray bitLen 128 31.852 ns/op 32.219 ns/op 0.99
intersect array and set length 128 853.01 ns/op 804.14 ns/op 1.06
bitArray.getTrueBitIndexes() bitLen 128 1.5430 us/op 1.6680 us/op 0.93
bitArray.getTrueBitIndexes() bitLen 248 2.7060 us/op 2.8610 us/op 0.95
bitArray.getTrueBitIndexes() bitLen 512 5.9430 us/op 5.6520 us/op 1.05
Buffer.concat 32 items 1.0940 us/op 1.0530 us/op 1.04
Uint8Array.set 32 items 2.1730 us/op 1.6480 us/op 1.32
Buffer.copy 2.2520 us/op 2.0870 us/op 1.08
Uint8Array.set - with subarray 3.5450 us/op 3.1450 us/op 1.13
Uint8Array.set - without subarray 2.1800 us/op 2.1470 us/op 1.02
Set add up to 64 items then delete first 3.0841 us/op 2.4040 us/op 1.28
OrderedSet add up to 64 items then delete first 5.0229 us/op 3.8233 us/op 1.31
Set add up to 64 items then delete last 3.2610 us/op 2.8666 us/op 1.14
OrderedSet add up to 64 items then delete last 4.8298 us/op 4.0678 us/op 1.19
Set add up to 64 items then delete middle 3.5043 us/op 2.9891 us/op 1.17
OrderedSet add up to 64 items then delete middle 6.8658 us/op 5.5580 us/op 1.24
Set add up to 128 items then delete first 7.3087 us/op 6.1967 us/op 1.18
OrderedSet add up to 128 items then delete first 10.788 us/op 9.2171 us/op 1.17
Set add up to 128 items then delete last 6.4792 us/op 5.9352 us/op 1.09
OrderedSet add up to 128 items then delete last 10.332 us/op 9.9482 us/op 1.04
Set add up to 128 items then delete middle 6.8983 us/op 6.5788 us/op 1.05
OrderedSet add up to 128 items then delete middle 17.767 us/op 16.918 us/op 1.05
Set add up to 256 items then delete first 14.285 us/op 13.968 us/op 1.02
OrderedSet add up to 256 items then delete first 22.294 us/op 18.672 us/op 1.19
Set add up to 256 items then delete last 13.463 us/op 12.917 us/op 1.04
OrderedSet add up to 256 items then delete last 20.469 us/op 18.707 us/op 1.09
Set add up to 256 items then delete middle 12.981 us/op 12.528 us/op 1.04
OrderedSet add up to 256 items then delete middle 50.098 us/op 46.636 us/op 1.07
transfer serialized Status (84 B) 1.5810 us/op 1.6150 us/op 0.98
copy serialized Status (84 B) 1.3430 us/op 1.3580 us/op 0.99
transfer serialized SignedVoluntaryExit (112 B) 1.7960 us/op 1.7250 us/op 1.04
copy serialized SignedVoluntaryExit (112 B) 1.4900 us/op 1.3390 us/op 1.11
transfer serialized ProposerSlashing (416 B) 3.0200 us/op 2.5470 us/op 1.19
copy serialized ProposerSlashing (416 B) 2.7420 us/op 2.7390 us/op 1.00
transfer serialized Attestation (485 B) 2.3780 us/op 2.4160 us/op 0.98
copy serialized Attestation (485 B) 2.1820 us/op 2.5210 us/op 0.87
transfer serialized AttesterSlashing (33232 B) 3.2430 us/op 2.3410 us/op 1.39
copy serialized AttesterSlashing (33232 B) 8.8940 us/op 7.8020 us/op 1.14
transfer serialized Small SignedBeaconBlock (128000 B) 3.4140 us/op 3.0030 us/op 1.14
copy serialized Small SignedBeaconBlock (128000 B) 26.214 us/op 22.073 us/op 1.19
transfer serialized Avg SignedBeaconBlock (200000 B) 4.0080 us/op 3.9160 us/op 1.02
copy serialized Avg SignedBeaconBlock (200000 B) 42.982 us/op 29.607 us/op 1.45
transfer serialized BlobsSidecar (524380 B) 4.4750 us/op 3.7580 us/op 1.19
copy serialized BlobsSidecar (524380 B) 123.26 us/op 140.72 us/op 0.88
transfer serialized Big SignedBeaconBlock (1000000 B) 5.2630 us/op 4.4420 us/op 1.18
copy serialized Big SignedBeaconBlock (1000000 B) 244.21 us/op 210.33 us/op 1.16
pass gossip attestations to forkchoice per slot 3.7671 ms/op 3.2589 ms/op 1.16
forkChoice updateHead vc 100000 bc 64 eq 0 751.05 us/op 521.16 us/op 1.44
forkChoice updateHead vc 600000 bc 64 eq 0 4.3241 ms/op 4.1609 ms/op 1.04
forkChoice updateHead vc 1000000 bc 64 eq 0 7.0045 ms/op 6.1514 ms/op 1.14
forkChoice updateHead vc 600000 bc 320 eq 0 5.0625 ms/op 3.3919 ms/op 1.49
forkChoice updateHead vc 600000 bc 1200 eq 0 4.7721 ms/op 3.5644 ms/op 1.34
forkChoice updateHead vc 600000 bc 7200 eq 0 6.2838 ms/op 4.0178 ms/op 1.56
forkChoice updateHead vc 600000 bc 64 eq 1000 12.448 ms/op 11.662 ms/op 1.07
forkChoice updateHead vc 600000 bc 64 eq 10000 12.929 ms/op 11.331 ms/op 1.14
forkChoice updateHead vc 600000 bc 64 eq 300000 37.173 ms/op 23.090 ms/op 1.61
computeDeltas 500000 validators 300 proto nodes 4.5902 ms/op 4.3691 ms/op 1.05
computeDeltas 500000 validators 1200 proto nodes 4.6143 ms/op 4.7592 ms/op 0.97
computeDeltas 500000 validators 7200 proto nodes 5.4860 ms/op 4.4505 ms/op 1.23
computeDeltas 750000 validators 300 proto nodes 7.2403 ms/op 5.5877 ms/op 1.30
computeDeltas 750000 validators 1200 proto nodes 7.0111 ms/op 5.7548 ms/op 1.22
computeDeltas 750000 validators 7200 proto nodes 7.5344 ms/op 5.8303 ms/op 1.29
computeDeltas 1400000 validators 300 proto nodes 14.344 ms/op 10.517 ms/op 1.36
computeDeltas 1400000 validators 1200 proto nodes 13.590 ms/op 10.867 ms/op 1.25
computeDeltas 1400000 validators 7200 proto nodes 12.732 ms/op 11.474 ms/op 1.11
computeDeltas 2100000 validators 300 proto nodes 18.963 ms/op 18.107 ms/op 1.05
computeDeltas 2100000 validators 1200 proto nodes 18.928 ms/op 20.169 ms/op 0.94
computeDeltas 2100000 validators 7200 proto nodes 18.898 ms/op 18.247 ms/op 1.04
altair processAttestation - 250000 vs - 7PWei normalcase 2.9237 ms/op 2.8655 ms/op 1.02
altair processAttestation - 250000 vs - 7PWei worstcase 4.0790 ms/op 3.4938 ms/op 1.17
altair processAttestation - setStatus - 1/6 committees join 137.93 us/op 142.64 us/op 0.97
altair processAttestation - setStatus - 1/3 committees join 245.28 us/op 259.36 us/op 0.95
altair processAttestation - setStatus - 1/2 committees join 334.32 us/op 378.15 us/op 0.88
altair processAttestation - setStatus - 2/3 committees join 414.71 us/op 460.29 us/op 0.90
altair processAttestation - setStatus - 4/5 committees join 599.22 us/op 657.73 us/op 0.91
altair processAttestation - setStatus - 100% committees join 730.06 us/op 792.31 us/op 0.92
altair processBlock - 250000 vs - 7PWei normalcase 6.0275 ms/op 4.7554 ms/op 1.27
altair processBlock - 250000 vs - 7PWei normalcase hashState 32.029 ms/op 30.897 ms/op 1.04
altair processBlock - 250000 vs - 7PWei worstcase 50.475 ms/op 48.156 ms/op 1.05
altair processBlock - 250000 vs - 7PWei worstcase hashState 110.13 ms/op 88.419 ms/op 1.25
phase0 processBlock - 250000 vs - 7PWei normalcase 2.8899 ms/op 2.8621 ms/op 1.01
phase0 processBlock - 250000 vs - 7PWei worstcase 35.208 ms/op 30.536 ms/op 1.15
altair processEth1Data - 250000 vs - 7PWei normalcase 584.83 us/op 391.14 us/op 1.50
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 7.9260 us/op 7.7250 us/op 1.03
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 29.299 us/op 27.056 us/op 1.08
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 11.562 us/op 12.743 us/op 0.91
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 7.9300 us/op 9.2640 us/op 0.86
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 97.341 us/op 149.26 us/op 0.65
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 869.13 us/op 798.23 us/op 1.09
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.0624 ms/op 1.1867 ms/op 0.90
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 972.34 us/op 1.1645 ms/op 0.84
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.9261 ms/op 2.5502 ms/op 1.15
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.8860 ms/op 2.0610 ms/op 0.92
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 4.9988 ms/op 4.5036 ms/op 1.11
Tree 40 250000 create 388.38 ms/op 260.90 ms/op 1.49
Tree 40 250000 get(125000) 190.59 ns/op 166.49 ns/op 1.14
Tree 40 250000 set(125000) 1.0110 us/op 768.87 ns/op 1.31
Tree 40 250000 toArray() 22.838 ms/op 21.085 ms/op 1.08
Tree 40 250000 iterate all - toArray() + loop 22.839 ms/op 19.344 ms/op 1.18
Tree 40 250000 iterate all - get(i) 63.564 ms/op 58.681 ms/op 1.08
MutableVector 250000 create 10.785 ms/op 10.160 ms/op 1.06
MutableVector 250000 get(125000) 7.1620 ns/op 11.924 ns/op 0.60
MutableVector 250000 set(125000) 399.00 ns/op 212.76 ns/op 1.88
MutableVector 250000 toArray() 4.9746 ms/op 3.9661 ms/op 1.25
MutableVector 250000 iterate all - toArray() + loop 4.8717 ms/op 3.9903 ms/op 1.22
MutableVector 250000 iterate all - get(i) 1.7889 ms/op 1.6893 ms/op 1.06
Array 250000 create 4.5202 ms/op 3.1815 ms/op 1.42
Array 250000 clone - spread 2.3611 ms/op 1.3949 ms/op 1.69
Array 250000 get(125000) 0.48200 ns/op 0.42600 ns/op 1.13
Array 250000 set(125000) 0.52300 ns/op 0.44300 ns/op 1.18
Array 250000 iterate all - loop 124.46 us/op 86.300 us/op 1.44
effectiveBalanceIncrements clone Uint8Array 300000 76.482 us/op 36.500 us/op 2.10
effectiveBalanceIncrements clone MutableVector 300000 142.00 ns/op 126.00 ns/op 1.13
effectiveBalanceIncrements rw all Uint8Array 300000 220.08 us/op 204.11 us/op 1.08
effectiveBalanceIncrements rw all MutableVector 300000 101.77 ms/op 80.371 ms/op 1.27
phase0 afterProcessEpoch - 250000 vs - 7PWei 102.92 ms/op 92.844 ms/op 1.11
phase0 beforeProcessEpoch - 250000 vs - 7PWei 55.092 ms/op 42.567 ms/op 1.29
altair processEpoch - mainnet_e81889 413.85 ms/op 453.51 ms/op 0.91
mainnet_e81889 - altair beforeProcessEpoch 74.135 ms/op 71.026 ms/op 1.04
mainnet_e81889 - altair processJustificationAndFinalization 12.769 us/op 19.023 us/op 0.67
mainnet_e81889 - altair processInactivityUpdates 6.7470 ms/op 7.4185 ms/op 0.91
mainnet_e81889 - altair processRewardsAndPenalties 39.270 ms/op 54.610 ms/op 0.72
mainnet_e81889 - altair processRegistryUpdates 2.0190 us/op 2.6370 us/op 0.77
mainnet_e81889 - altair processSlashings 415.00 ns/op 658.00 ns/op 0.63
mainnet_e81889 - altair processEth1DataReset 334.00 ns/op 587.00 ns/op 0.57
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.1327 ms/op 2.2126 ms/op 0.51
mainnet_e81889 - altair processSlashingsReset 2.7160 us/op 3.9370 us/op 0.69
mainnet_e81889 - altair processRandaoMixesReset 3.4890 us/op 7.2480 us/op 0.48
mainnet_e81889 - altair processHistoricalRootsUpdate 774.00 ns/op 634.00 ns/op 1.22
mainnet_e81889 - altair processParticipationFlagUpdates 2.5460 us/op 3.0200 us/op 0.84
mainnet_e81889 - altair processSyncCommitteeUpdates 710.00 ns/op 422.00 ns/op 1.68
mainnet_e81889 - altair afterProcessEpoch 98.651 ms/op 95.619 ms/op 1.03
capella processEpoch - mainnet_e217614 1.4614 s/op 1.5241 s/op 0.96
mainnet_e217614 - capella beforeProcessEpoch 299.40 ms/op 307.40 ms/op 0.97
mainnet_e217614 - capella processJustificationAndFinalization 20.291 us/op 24.349 us/op 0.83
mainnet_e217614 - capella processInactivityUpdates 20.869 ms/op 20.315 ms/op 1.03
mainnet_e217614 - capella processRewardsAndPenalties 271.29 ms/op 253.57 ms/op 1.07
mainnet_e217614 - capella processRegistryUpdates 15.128 us/op 27.355 us/op 0.55
mainnet_e217614 - capella processSlashings 865.00 ns/op 862.00 ns/op 1.00
mainnet_e217614 - capella processEth1DataReset 1.6560 us/op 1.1810 us/op 1.40
mainnet_e217614 - capella processEffectiveBalanceUpdates 5.9575 ms/op 4.3216 ms/op 1.38
mainnet_e217614 - capella processSlashingsReset 7.9030 us/op 6.7000 us/op 1.18
mainnet_e217614 - capella processRandaoMixesReset 5.9620 us/op 8.4330 us/op 0.71
mainnet_e217614 - capella processHistoricalRootsUpdate 1.3290 us/op 1.2130 us/op 1.10
mainnet_e217614 - capella processParticipationFlagUpdates 3.0360 us/op 5.0960 us/op 0.60
mainnet_e217614 - capella afterProcessEpoch 344.52 ms/op 364.51 ms/op 0.95
phase0 processEpoch - mainnet_e58758 441.97 ms/op 519.46 ms/op 0.85
mainnet_e58758 - phase0 beforeProcessEpoch 118.15 ms/op 180.67 ms/op 0.65
mainnet_e58758 - phase0 processJustificationAndFinalization 24.987 us/op 35.434 us/op 0.71
mainnet_e58758 - phase0 processRewardsAndPenalties 44.683 ms/op 46.268 ms/op 0.97
mainnet_e58758 - phase0 processRegistryUpdates 11.845 us/op 21.155 us/op 0.56
mainnet_e58758 - phase0 processSlashings 508.00 ns/op 1.1210 us/op 0.45
mainnet_e58758 - phase0 processEth1DataReset 899.00 ns/op 1.1960 us/op 0.75
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.2328 ms/op 1.4624 ms/op 0.84
mainnet_e58758 - phase0 processSlashingsReset 6.2280 us/op 7.5180 us/op 0.83
mainnet_e58758 - phase0 processRandaoMixesReset 8.3750 us/op 17.020 us/op 0.49
mainnet_e58758 - phase0 processHistoricalRootsUpdate 726.00 ns/op 1.8460 us/op 0.39
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.0030 us/op 7.8430 us/op 0.51
mainnet_e58758 - phase0 afterProcessEpoch 91.150 ms/op 97.829 ms/op 0.93
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.9104 ms/op 2.1485 ms/op 0.89
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.2870 ms/op 5.5777 ms/op 0.59
altair processInactivityUpdates - 250000 normalcase 24.511 ms/op 44.582 ms/op 0.55
altair processInactivityUpdates - 250000 worstcase 21.961 ms/op 41.648 ms/op 0.53
phase0 processRegistryUpdates - 250000 normalcase 14.100 us/op 24.392 us/op 0.58
phase0 processRegistryUpdates - 250000 badcase_full_deposits 367.19 us/op 575.85 us/op 0.64
phase0 processRegistryUpdates - 250000 worstcase 0.5 149.14 ms/op 248.18 ms/op 0.60
altair processRewardsAndPenalties - 250000 normalcase 52.556 ms/op 69.419 ms/op 0.76
altair processRewardsAndPenalties - 250000 worstcase 56.244 ms/op 62.825 ms/op 0.90
phase0 getAttestationDeltas - 250000 normalcase 12.074 ms/op 9.0118 ms/op 1.34
phase0 getAttestationDeltas - 250000 worstcase 11.414 ms/op 12.416 ms/op 0.92
phase0 processSlashings - 250000 worstcase 98.957 us/op 143.38 us/op 0.69
altair processSyncCommitteeUpdates - 250000 180.98 ms/op 165.87 ms/op 1.09
BeaconState.hashTreeRoot - No change 492.00 ns/op 550.00 ns/op 0.89
BeaconState.hashTreeRoot - 1 full validator 150.63 us/op 171.25 us/op 0.88
BeaconState.hashTreeRoot - 32 full validator 1.3862 ms/op 1.6724 ms/op 0.83
BeaconState.hashTreeRoot - 512 full validator 14.964 ms/op 16.993 ms/op 0.88
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 163.23 us/op 197.98 us/op 0.82
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.7423 ms/op 3.1747 ms/op 0.86
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 33.154 ms/op 42.084 ms/op 0.79
BeaconState.hashTreeRoot - 1 balances 120.80 us/op 168.96 us/op 0.72
BeaconState.hashTreeRoot - 32 balances 1.1467 ms/op 1.3825 ms/op 0.83
BeaconState.hashTreeRoot - 512 balances 10.970 ms/op 13.760 ms/op 0.80
BeaconState.hashTreeRoot - 250000 balances 216.13 ms/op 259.23 ms/op 0.83
aggregationBits - 2048 els - zipIndexesInBitList 42.460 us/op 52.278 us/op 0.81
byteArrayEquals 32 62.940 ns/op 72.331 ns/op 0.87
Buffer.compare 32 21.295 ns/op 20.177 ns/op 1.06
byteArrayEquals 1024 1.8193 us/op 1.8296 us/op 0.99
Buffer.compare 1024 29.636 ns/op 33.251 ns/op 0.89
byteArrayEquals 16384 29.255 us/op 34.748 us/op 0.84
Buffer.compare 16384 233.42 ns/op 238.54 ns/op 0.98
byteArrayEquals 123687377 228.51 ms/op 221.47 ms/op 1.03
Buffer.compare 123687377 11.541 ms/op 10.757 ms/op 1.07
byteArrayEquals 32 - diff last byte 60.769 ns/op 64.749 ns/op 0.94
Buffer.compare 32 - diff last byte 19.374 ns/op 21.449 ns/op 0.90
byteArrayEquals 1024 - diff last byte 1.8088 us/op 1.8331 us/op 0.99
Buffer.compare 1024 - diff last byte 30.825 ns/op 31.130 ns/op 0.99
byteArrayEquals 16384 - diff last byte 29.356 us/op 28.638 us/op 1.03
Buffer.compare 16384 - diff last byte 234.95 ns/op 251.13 ns/op 0.94
byteArrayEquals 123687377 - diff last byte 219.85 ms/op 222.92 ms/op 0.99
Buffer.compare 123687377 - diff last byte 10.384 ms/op 10.907 ms/op 0.95
byteArrayEquals 32 - random bytes 6.0180 ns/op 5.8090 ns/op 1.04
Buffer.compare 32 - random bytes 20.217 ns/op 19.579 ns/op 1.03
byteArrayEquals 1024 - random bytes 6.0560 ns/op 5.7900 ns/op 1.05
Buffer.compare 1024 - random bytes 19.940 ns/op 19.606 ns/op 1.02
byteArrayEquals 16384 - random bytes 5.8320 ns/op 6.3260 ns/op 0.92
Buffer.compare 16384 - random bytes 20.541 ns/op 21.721 ns/op 0.95
byteArrayEquals 123687377 - random bytes 7.4200 ns/op 7.6200 ns/op 0.97
Buffer.compare 123687377 - random bytes 21.700 ns/op 23.150 ns/op 0.94
regular array get 100000 times 35.894 us/op 51.564 us/op 0.70
wrappedArray get 100000 times 36.682 us/op 48.475 us/op 0.76
arrayWithProxy get 100000 times 14.654 ms/op 14.610 ms/op 1.00
ssz.Root.equals 51.526 ns/op 61.906 ns/op 0.83
byteArrayEquals 51.275 ns/op 60.564 ns/op 0.85
Buffer.compare 11.960 ns/op 11.986 ns/op 1.00
shuffle list - 16384 els 7.2498 ms/op 7.4740 ms/op 0.97
shuffle list - 250000 els 104.38 ms/op 107.55 ms/op 0.97
processSlot - 1 slots 17.598 us/op 17.694 us/op 0.99
processSlot - 32 slots 3.4914 ms/op 4.2606 ms/op 0.82
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 44.063 ms/op 45.651 ms/op 0.97
getCommitteeAssignments - req 1 vs - 250000 vc 2.4395 ms/op 2.4114 ms/op 1.01
getCommitteeAssignments - req 100 vs - 250000 vc 4.7319 ms/op 4.7120 ms/op 1.00
getCommitteeAssignments - req 1000 vs - 250000 vc 5.1000 ms/op 5.1846 ms/op 0.98
findModifiedValidators - 10000 modified validators 378.38 ms/op 402.36 ms/op 0.94
findModifiedValidators - 1000 modified validators 195.86 ms/op 274.93 ms/op 0.71
findModifiedValidators - 100 modified validators 251.25 ms/op 273.87 ms/op 0.92
findModifiedValidators - 10 modified validators 262.86 ms/op 300.46 ms/op 0.87
findModifiedValidators - 1 modified validators 325.41 ms/op 293.70 ms/op 1.11
findModifiedValidators - no difference 287.54 ms/op 251.25 ms/op 1.14
compare ViewDUs 3.7890 s/op 3.7823 s/op 1.00
compare each validator Uint8Array 1.6680 s/op 1.4968 s/op 1.11
compare ViewDU to Uint8Array 1.3506 s/op 1.3891 s/op 0.97
migrate state 1000000 validators, 24 modified, 0 new 625.82 ms/op 644.09 ms/op 0.97
migrate state 1000000 validators, 1700 modified, 1000 new 786.67 ms/op 940.56 ms/op 0.84
migrate state 1000000 validators, 3400 modified, 2000 new 1.0142 s/op 1.1098 s/op 0.91
migrate state 1500000 validators, 24 modified, 0 new 635.46 ms/op 666.40 ms/op 0.95
migrate state 1500000 validators, 1700 modified, 1000 new 914.73 ms/op 875.14 ms/op 1.05
migrate state 1500000 validators, 3400 modified, 2000 new 1.2009 s/op 1.1537 s/op 1.04
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.7300 ns/op 5.4900 ns/op 1.04
state getBlockRootAtSlot - 250000 vs - 7PWei 682.02 ns/op 925.59 ns/op 0.74
computeProposers - vc 250000 10.984 ms/op 9.4029 ms/op 1.17
computeEpochShuffling - vc 250000 112.49 ms/op 99.655 ms/op 1.13
getNextSyncCommittee - vc 250000 162.01 ms/op 143.49 ms/op 1.13
computeSigningRoot for AttestationData 27.354 us/op 24.238 us/op 1.13
hash AttestationData serialized data then Buffer.toString(base64) 1.8385 us/op 1.6802 us/op 1.09
toHexString serialized data 1.4917 us/op 1.1644 us/op 1.28
Buffer.toString(base64) 227.69 ns/op 229.40 ns/op 0.99

by benchmarkbot/action

@wemeetagain
Copy link
Member

lint failed but otherwise LGTM

nflaig
nflaig reviewed Jun 25, 2024
View reviewed changes
packages/beacon-node/test/spec/presets/genesis.test.ts Outdated Show resolved Hide resolved
packages/beacon-node/test/spec/presets/genesis.test.ts Outdated Show resolved Hide resolved
packages/beacon-node/test/spec/presets/light_client/sync.ts Outdated Show resolved Hide resolved
packages/beacon-node/test/spec/presets/light_client/update_ranking.ts Outdated Show resolved Hide resolved
packages/beacon-node/test/spec/presets/operations.test.ts Outdated Show resolved Hide resolved
packages/beacon-node/test/spec/presets/ssz_static.test.ts Outdated Show resolved Hide resolved
packages/params/src/forkName.ts Outdated Show resolved Hide resolved
packages/params/src/forkName.ts Outdated Show resolved Hide resolved
packages/params/src/forkName.ts Outdated Show resolved Hide resolved
@nazarhussain nazarhussain requested a review from nflaig June 26, 2024 06:05
@wemeetagain wemeetagain enabled auto-merge (squash) June 27, 2024 21:02
@wemeetagain wemeetagain merged commit f69bc11 into unstable Jun 27, 2024
18 of 20 checks passed
@wemeetagain wemeetagain deleted the nh/types-merge-all branch June 27, 2024 21:19
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.20.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@nflaig nflaig Awaiting requested review from nflaig

Assignees

@nazarhussain nazarhussain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nazarhussain @wemeetagain @nflaig