-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add warning log to notifier if execution client is offline #6919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #6919 +/- ##
=========================================
Coverage 62.52% 62.52%
=========================================
Files 575 575
Lines 60985 60985
Branches 2118 2121 +3
=========================================
+ Hits 38128 38129 +1
+ Misses 22818 22817 -1
Partials 39 39 |
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Jul 5, 2024
🎉 This PR is included in v1.20.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are pretty silent about the execution client being offline after the initial error. The logs just show that the node is stalling and not updating head but we should make it more apparent that the issue is related to EL being offline and also notify the user about the issue.
Most users (including myself) just check the logs of the consensus client to see if their node is performing well and healthy.
Description
Add warning log to notifier if execution client is offline. The warning will be logged at the start of every epoch if EL is offline.
Related #6861