-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: default to json if client accepts all media types #6950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Jul 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #6950 +/- ##
=========================================
Coverage 62.51% 62.51%
=========================================
Files 575 575
Lines 61015 61020 +5
Branches 2120 2124 +4
=========================================
+ Hits 38141 38147 +6
+ Misses 22835 22834 -1
Partials 39 39 |
wemeetagain
approved these changes
Jul 15, 2024
🎉 This PR is included in v1.20.1 🎉 |
🎉 This PR is included in v1.21.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This allows to query beacon api via browser URL input field.
By default chrome browser sets a header like this
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.7
It does not explicitly state that it wants ssz or json but it adds
*/*
with q=0.8, while this is handled correctly for a header that solely uses this value, it does not work in a quality weighted header right now.Currently Lodestar returns the following error
Description
Default to json if client accepts all media types as part of quality weighted accept header.
Note: we will still return ssz data if
application/octet-stream
is part of the Accept header with a higher weight