Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: log sync aggregate participants when producing beacon block body #7300

Merged
merged 3 commits into from
Dec 15, 2024
Merged

chore: log sync aggregate participants when producing beacon block body #7300

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f291b81
chore: log sync aggregate participants when producing beacon block body
nflaig Dec 13, 2024
389c342
Use isForkLightClient instead of ForkSeq
nflaig Dec 13, 2024
b064b55
Fix produce block unit tests
nflaig Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions packages/beacon-node/src/chain/produceBlock/produceBlockBody.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,15 @@ export async function produceBlockBody<T extends BlockType>(
? Object.assign({}, commonBlockBody)
: await produceCommonBlockBody.call(this, blockType, currentState, blockAttr);

const {attestations, deposits, voluntaryExits, attesterSlashings, proposerSlashings, blsToExecutionChanges} =
blockBody;
const {
attestations,
deposits,
voluntaryExits,
attesterSlashings,
proposerSlashings,
syncAggregate,
blsToExecutionChanges,
} = blockBody;

Object.assign(logMeta, {
attestations: attestations.length,
Expand All @@ -154,6 +161,12 @@ export async function produceBlockBody<T extends BlockType>(
proposerSlashings: proposerSlashings.length,
});

if (ForkSeq[fork] >= ForkSeq.altair) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to use isForkLightClient(fork) so it's aligned with isForkExecution(fork) at L171?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure we can but if you look further down we use the ForkSeq

lodestar/packages/beacon-node/src/chain/produceBlock/produceBlockBody.ts

Line 211 in 99794d3

if (ForkSeq[fork] >= ForkSeq.deneb) {

but since those are close together can use isForkLightClient here, doesn't matter much but wanna avoid too much refactoring in this PR

Object.assign(logMeta, {
syncAggregateParticipants: syncAggregate.syncCommitteeBits.getTrueBitIndexes().length,
});
}

const endExecutionPayload = stepsMetrics?.startTimer();
if (isForkExecution(fork)) {
const safeBlockHash = this.forkChoice.getJustifiedBlock().executionPayloadBlockHash ?? ZERO_HASH_HEX;
Expand Down
Loading