-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement ViewDU.batchHashTreeRoot() #392
Conversation
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
I should have mentioned the new |
this is part 1 of |
Motivation
batchHashTreeRoot()
for ViewDU type based onHashComputation
Description
hashTreeRoot()
is still great because it does not allocate any memory so we need a new method to compute batchpackages/ssz/src/viewDU/abstract.ts
, addbatchHashTreeRoot()
methodHashComputationGroup
in previous PR 389commit()
method:hcByLevel
is null, it means it was called fromhashTreeRoot()
,commit()
method should be backward compatible in this casehcByLevel
, it should compute root because this ViewDU does not supportHashComputation
cherry picked from #378
Unit Tests
batchHashTreeRoot()
returns the same value tohashTreeRoot
, please suggest if we need morepart of #355