Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corrected yarn add statement in README.md #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SantiagoDevRel
Copy link

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@Muhammad-Altabba Muhammad-Altabba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SantiagoDevRel for catching this.

Comment on lines +28 to +36
- Corrected the `yarn add` statement for the Chainlink web3.js plugin.
- Previously, the documentation incorrectly stated:
```
yarn add @chainsafe/web3.js-chainlink-plugin
```
However, the correct yarn statement is:
```
yarn add "@chainsafe/web3-plugin-chainlink";
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep the CHANGELOG.md simple, we put one line for the change and we include the PR number. And any description we would like to associate would be at the PR description (you can edit it).

Suggested change
- Corrected the `yarn add` statement for the Chainlink web3.js plugin.
- Previously, the documentation incorrectly stated:
```
yarn add @chainsafe/web3.js-chainlink-plugin
```
However, the correct yarn statement is:
```
yarn add "@chainsafe/web3-plugin-chainlink";
```
- Corrected the `yarn add` statement according to the new package name (#34)

@SantiagoDevRel SantiagoDevRel changed the title corrected yarn add statement in README.md fix: corrected yarn add statement in README.md Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants