Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

[ENHANCEMENT] Update error boundary answer #161

Merged
merged 3 commits into from
Aug 12, 2019
Merged

[ENHANCEMENT] Update error boundary answer #161

merged 3 commits into from
Aug 12, 2019

Conversation

Tolsee
Copy link

@Tolsee Tolsee commented Aug 10, 2019 •
edited
Loading

Description

Now, react recommends using static getDerivedStateFromError method for updating state. And, they are eventually going to deprecate the use of componentDidCatch for updating state. So, I have changed the use of those methods appropriately in the example.

Resolves #(issue number)

What does your PR belong to?

  • Questions / Answers
  • Website
  • General / Things regarding the repository (like CI Integration)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking improvement of a question)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have checked that the changes are working properly
  • I have checked that there isn't any PR doing the same
  • I have read the CONTRIBUTING document.

@fejes713 fejes713 requested a review from Chalarangelo August 10, 2019 18:27
@fejes713 fejes713 added the opinions needed We need more opinions on this one label Aug 10, 2019
skatcat31
skatcat31 suggested changes Aug 11, 2019
View reviewed changes
Copy link
Contributor

@skatcat31 skatcat31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes are needed before merging, one for grammar, one for markdown instead of HTML

questions/error-boundaries.md Outdated Show resolved Hide resolved
questions/error-boundaries.md Outdated Show resolved Hide resolved
Tolsee and others added 2 commits August 12, 2019 07:49
@Tolsee @skatcat31
markup instead of html bold
938b275 
Co-Authored-By: Robert Mennell <skatcat31@users.noreply.github.com>
@Tolsee @skatcat31
Grammar change
d4c6a9c 
Co-Authored-By: Robert Mennell <skatcat31@users.noreply.github.com>
@Tolsee
Copy link
Author

Tolsee commented Aug 12, 2019

@skatcat31 Thanks for the feedback!

@Chalarangelo Chalarangelo merged commit 8a90ed9 into Chalarangelo:master Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@skatcat31 skatcat31 skatcat31 approved these changes

@Chalarangelo Chalarangelo Chalarangelo approved these changes

Assignees
No one assigned
Labels
opinions needed We need more opinions on this one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tolsee @Chalarangelo @skatcat31 @fejes713