-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Banning users #90
Banning users #90
Conversation
Ban Zidail :D (The guy from #48) |
An alternative, less harsh, approach would be to at least have chaosbot comment on PRs from people with previous PRs deemed really bad by the community. Could be as simple as "Hey this guy might be malicious/spam". This gives a heads up for everybody |
@rudehn that sounds interesting. I'll work on it later. |
I prefer rudehn's idea for chaosbot leaving a comment on PRs I think part of the fun in chaosbot is everyone has a vote. Made me happy when I read that democracy vote got accepted. ( Removal of following bonus ) |
@MINIMAN10000 interestingly the pr got reverted due to server error. Coincidence? |
@@ -100,6 +100,7 @@ def get_ready_prs(api, urn, window): | |||
open_prs = get_open_prs(api, urn) | |||
for pr in open_prs: | |||
pr_num = pr["number"] | |||
user = pr["user"]["id"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use "login" instead of "id"... it's pretty tricky to find your id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can change login
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wow, did not know
🙅 This PR did not meet the required vote threshold and will not be merged. Closing. Open a new PR to restart voting. |
It might be a good idea to ignore prs from users wjo are banned.
Ideas for further improvement: