Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banning users #90

Closed
wants to merge 1 commit into from
Closed

Banning users #90

wants to merge 1 commit into from

Conversation

MCSH
Copy link

@MCSH MCSH commented May 23, 2017

It might be a good idea to ignore prs from users wjo are banned.

Ideas for further improvement:

  • add a poll method to ban a user (using issues preferably)
  • deny prs from banned users

@romgrk
Copy link

romgrk commented May 23, 2017

Ban Zidail :D (The guy from #48)

@rudehn
Copy link
Contributor

rudehn commented May 23, 2017

An alternative, less harsh, approach would be to at least have chaosbot comment on PRs from people with previous PRs deemed really bad by the community.

Could be as simple as "Hey this guy might be malicious/spam".

This gives a heads up for everybody

@MCSH
Copy link
Author

MCSH commented May 23, 2017

@rudehn that sounds interesting. I'll work on it later.

@MINIMAN10000
Copy link
Contributor

I prefer rudehn's idea for chaosbot leaving a comment on PRs

I think part of the fun in chaosbot is everyone has a vote. Made me happy when I read that democracy vote got accepted. ( Removal of following bonus )

@MCSH
Copy link
Author

MCSH commented May 23, 2017

@MINIMAN10000 interestingly the pr got reverted due to server error.

f2cd29e

Coincidence?

@@ -100,6 +100,7 @@ def get_ready_prs(api, urn, window):
open_prs = get_open_prs(api, urn)
for pr in open_prs:
pr_num = pr["number"]
user = pr["user"]["id"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use "login" instead of "id"... it's pretty tricky to find your id

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can change login

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow, did not know

@chaosbot
Copy link
Collaborator

🙅 This PR did not meet the required vote threshold and will not be merged. Closing.

Open a new PR to restart voting.

@amoffat
Copy link
Contributor

amoffat commented May 23, 2017

If anyone is wondering why this got rejected, with #42 put in place, and with more yays than nays, the answer is here. User vote weights are cached for a day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants