Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented chat message queue dumping on exit #3899

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

user12986714
Copy link
Contributor

Implemented chat message queue dumping on exit. Upon restart, chat messages that were not posted in the last session will be restored.

Implemented chat message queue dumping on exit. Upon restart, chat messages that were not posted in the last session will be restored.
@makyen
Copy link
Contributor

makyen commented Jun 10, 2020

In general, I'd appreciate more comments that explain what your intent is. In reviewing, I shouldn't need to dig through the code cold, having to figure out how what you are implementing is intended to accomplish your overall goal; nor should it be necessary to dig through each section of code or function in order to get a general overview of what is supposed to be happening. It doesn't take a lot of comments, but there should be some to guide the person reading the code as to what is intended to be happening, and in general how that's being accomplished.

@stale stale bot added the status: stale label Jul 11, 2020
@stale
Copy link

stale bot commented Jul 12, 2020

This issue has been closed because it has had no recent activity. If this is still important, please add another comment and find someone with write permissions to reopen the issue. Thank you for your contributions.

@stale stale bot closed this Jul 12, 2020
@makyen makyen reopened this Jul 12, 2020
@stale stale bot removed the status: stale label Jul 12, 2020
@makyen makyen added the status: confirmed Confirmed as something that needs working on. label Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: confirmed Confirmed as something that needs working on.
Development

Successfully merging this pull request may close these issues.

3 participants